Uh oh!
There was an error while loading. Please reload this page.
Remove old legacy scripts references - #23999
Merged
Merged
Conversation
skjnldsv
requested review from
ChristophWurst, MorrisJobke, PVince81, blizzz, juliusknorr and rullzerNovember 9, 2020 11:24
skjnldsv
commented
Nov 9, 2020
MemberAuthor
/backport to stable20 |
skjnldsv
commented
Nov 9, 2020
MemberAuthor
/backport to stable19 |
skjnldsv
commented
Nov 9, 2020
MemberAuthor
/backport to stable18 |
rullzer
requested changes
Nov 9, 2020
| "sharedialogshareelistview.js", | ||
| "public/publicpage.js", | ||
| "setupchecks.js", | ||
| "../search/js/search.js", |
Member
There was a problem hiding this comment.
Are you sure this one can go as well in the backports?
MemberAuthor
There was a problem hiding this comment.
20 yeah, I'll remove for the others indeed :)
juliusknorr
approved these changes
Nov 9, 2020
This was referenced Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#21235
Bug present since stable16 apparently 🤷
Was removed by 8e9d259@ChristophWurst