Skip to content

allow selecting multiple columns with SELECT DISTINCT - #24007

Merged
MorrisJobke merged 1 commit into
masterfrom
select-distinct-multiple
Nov 19, 2020
Merged

allow selecting multiple columns with SELECT DISTINCT#24007
MorrisJobke merged 1 commit into
masterfrom
select-distinct-multiple

Conversation

@icewind1991

@icewind1991icewind1991 commented Nov 9, 2020

Copy link
Copy Markdown
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Nov 9, 2020
@icewind1991icewind1991 added this to the Nextcloud 21 milestone Nov 9, 2020
@icewind1991

icewind1991 commented Nov 9, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

nickvergessen
nickvergessen requested changes Nov 9, 2020
View reviewed changes
Comment threadtests/lib/DB/QueryBuilder/QueryBuilderTest.php Outdated
@icewind1991
icewind1991force-pushed the select-distinct-multiple branch from 99f0113 to 161a4f9CompareNovember 10, 2020 15:22
@nextcloudnextcloud deleted a comment from faily-botBotNov 10, 2020
MorrisJobke
MorrisJobke approved these changes Nov 10, 2020
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@nickvergessen

nickvergessen commented Nov 10, 2020

Copy link
Copy Markdown
Member

Let me run this on oracle tomorrow

@icewind1991@nickvergessen
allow selecting multiple columns with SELECT DISTINCT
a61a757
Signed-off-by: Robin Appelman <robin@icewind.nl>
@nickvergessen
nickvergessenforce-pushed the select-distinct-multiple branch from 161a4f9 to a61a757CompareNovember 16, 2020 14:45
@faily-bot

faily-botBot commented Nov 16, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35589: failure

mariadb10.1-php7.3

Show full log
There was 1 error:
1) Test\SystemTag\SystemTagManagerTest::testDeleteTagRemovesRelations
OCP\SystemTag\TagNotFoundException: Tag id(s) not found
/drone/src/lib/private/SystemTag/SystemTagManager.php:126
/drone/src/lib/private/SystemTag/SystemTagObjectMapper.php:258
/drone/src/lib/private/SystemTag/SystemTagObjectMapper.php:149
/drone/src/tests/lib/SystemTag/SystemTagManagerTest.php:408
--
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@MorrisJobke
MorrisJobke merged commit 1b613c8 into masterNov 19, 2020
@MorrisJobke
MorrisJobke deleted the select-distinct-multiple branch November 19, 2020 21:39
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Nov 19, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@nickvergessen@MorrisJobke