Uh oh!
There was an error while loading. Please reload this page.
[stable19] Fix sharing tab state not matching resharing admin settings - #24045
Merged
Conversation
backportbot-nextcloudBot
requested review from
ChristophWurst, MorrisJobke, danxuliu, juliusknorr, rullzer and skjnldsvNovember 11, 2020 08:34
danxuliu
requested changes
Nov 11, 2020
danxuliu
left a comment
Member
There was a problem hiding this comment.
I will take care of the conflicts.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliuforce-pushed
the
backport/24042/stable19
branch
from
November 11, 2020 10:47
8fbf24d to
cb62d94CompareSigned-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliuforce-pushed
the
backport/24042/stable19
branch
from
November 11, 2020 12:47
cb62d94 to
3af171dComparedanxuliu
approved these changes
Nov 11, 2020
danxuliu
left a comment
Member
There was a problem hiding this comment.
Tested and works 👍
The php-cs check failure is unrelated, as it happens too in other backports to stable19.
MorrisJobke
commented
Nov 11, 2020
Member
Yep - need to look into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #24042