Uh oh!
There was an error while loading. Please reload this page.
Check quota of subdirectories when uploading to them - #24102
Merged
Conversation
juliusknorr
requested review from
ChristophWurst, danxuliu, rullzer and skjnldsvNovember 13, 2020 11:48
3 tasks
skjnldsv
approved these changes
Nov 13, 2020
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Code make sense! Minimal legacy code changes too! 👍
Signed-off-by: Julius Härtl <jus@bitgrid.net>
ChristophWurst
approved these changes
Nov 17, 2020
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Tested and works. I can upload a file to an external sub directory while the user's root directory is full 👍
ChristophWurstforce-pushed
the
bugfix/noid/quota-upload
branch
from
November 17, 2020 08:31
2f0de61 to
0c19826CompareSigned-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurstforce-pushed
the
bugfix/noid/quota-upload
branch
from
November 17, 2020 08:44
0c19826 to
f9536b0Compare| mtime: parseInt($el.attr('data-mtime'), 10), | ||
| type: $el.attr('data-type'), | ||
| etag: $el.attr('data-etag'), | ||
| quotaAvailableBytes: $el.attr('data-quota'), |
There was a problem hiding this comment.
this will also be set for files, but I guess it's fine
ChristophWurst
approved these changes
Nov 17, 2020
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Still works after minor modifications :)
ChristophWurst
commented
Nov 17, 2020
Member
/backport to stable20 |
ChristophWurst
commented
Nov 17, 2020
Member
/backport to stable19 |
This was referenced Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Different attempt to #23294 to check the available space on a subdirectory when uploading a file by dragging it to the browser.