Skip to content

Check quota of subdirectories when uploading to them - #24102

Merged
ChristophWurst merged 2 commits into
masterfrom
bugfix/noid/quota-upload
Nov 17, 2020
Merged

Check quota of subdirectories when uploading to them#24102
ChristophWurst merged 2 commits into
masterfrom
bugfix/noid/quota-upload

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

Different attempt to #23294 to check the available space on a subdirectory when uploading a file by dragging it to the browser.

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code make sense! Minimal legacy code changes too! 👍

@juliusknorrjuliusknorr added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 16, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. I can upload a file to an external sub directory while the user's root directory is full 👍

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
mtime: parseInt($el.attr('data-mtime'), 10),
type: $el.attr('data-type'),
etag: $el.attr('data-etag'),
quotaAvailableBytes: $el.attr('data-quota'),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will also be set for files, but I guess it's fine

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works after minor modifications :)

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 17, 2020
@ChristophWurstChristophWurst added this to the Nextcloud 21 milestone Nov 17, 2020
@ChristophWurst

Copy link
Copy Markdown
Member

/backport to stable20

@ChristophWurst

Copy link
Copy Markdown
Member

/backport to stable19

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@ChristophWurst@skjnldsv