Uh oh!
There was an error while loading. Please reload this page.
Use correct year for generated birthdays events - #24108
Merged
Merged
Conversation
'X-APPLE-OMIT-YEAR' is not always present, at least iOS 12.4 uses the hard coded date of 1604 (the start of the gregorian calendar) when the year is unknown. cf. https://forums.bitfire.at/topic/2050/bday-without-year-for-vcard-3-0-if-server-drops-property-x-apple-omit-year and https://gitlab.com/CardBook/CardBook/-/issues/586 Signed-off-by: Sven Strickroth <email@cs-ware.de>
rullzer
requested review from
ChristophWurst, georgehrke, juliusknorr, nickvergessen and skjnldsvNovember 17, 2020 08:13
| if ($originalYear == 1604) { | ||
| $originalYear = null; | ||
| $unknownYear = true; | ||
| $birthday = '1970-' . $dateParts['month'] . '-' . $dateParts['date']; |
There was a problem hiding this comment.
could be omitted as $originalYear = null; triggers if ($originalYear < 1970) { below?
Or it should be an elseif to be more explicit?
ContributorAuthor
Thanks, please also backport this to NC19 |
csware
commented
Nov 20, 2020
ContributorAuthor
/backport to stable19 |
csware
commented
Nov 20, 2020
ContributorAuthor
/backport to stable20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'X-APPLE-OMIT-YEAR' is not always present, at least iOS 12.4 uses the hard coded date of 1604 when the year is unknown.
Without this PR people are shown as born in 1604 if not year is entered.
cf. https://forums.bitfire.at/topic/2050/bday-without-year-for-vcard-3-0-if-server-drops-property-x-apple-omit-year and https://gitlab.com/CardBook/CardBook/-/issues/586
Also needed for older Nextcloud versions such as 19