Skip to content

Fix nextcloud logo in email notifications misalignment - #24135

Merged
rullzer merged 1 commit into
nextcloud:masterfrom
medical-cloud:fix/23357-nextcloud-logo-in-email-notifications-is-misaligned-in-version-20
Nov 19, 2020
Merged

Fix nextcloud logo in email notifications misalignment #24135
rullzer merged 1 commit into
nextcloud:masterfrom
medical-cloud:fix/23357-nextcloud-logo-in-email-notifications-is-misaligned-in-version-20

Conversation

@medcloud

@medcloudmedcloud commented Nov 14, 2020

Copy link
Copy Markdown
Contributor

Signed-off-by: medcloud 42641918+medcloud@users.noreply.github.com

Fixes the good positionning of theming logo in the circle when sending emails (like share by email or by link) : the logo was on the top of the circle, and circle sometimes on the left aligned in iOS Gmail for instance.

The modification proposed is mainly focused on a square logo which would be correctly centered. However, for a logo like Nextcloud one (252x120px) the display is a bit different but acceptable.

Fix#23357
Fix#23977

@medcloud

This comment has been minimized.

@skjnldsvskjnldsv changed the title Fix #23357 #23977Fix nextcloud logo in email notifications misalignment Nov 14, 2020
@skjnldsvskjnldsv added this to the Nextcloud 21 milestone Nov 14, 2020
Comment threadlib/private/Mail/EMailTemplate.php Outdated

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the other code syntax fix, 👍

@skjnldsv

Copy link
Copy Markdown
Member

Last time, "continuous-integration/drone/pr had failed, would you know if there is something to do for that ?

Ah right, you need to fix the tests on tests/lib/Mail/EMailTemplateTest.php
https://drone.nextcloud.com/nextcloud/server/35550/10/4

@kurn77kurn77 mentioned this pull request Nov 18, 2020
Signed-off-by: medcloud <42641918+medcloud@users.noreply.github.com>
@medcloud

medcloud commented Nov 18, 2020

Copy link
Copy Markdown
ContributorAuthor

Last time, "continuous-integration/drone/pr had failed, would you know if there is something to do for that ?

Ah right, you need to fix the tests on tests/lib/Mail/EMailTemplateTest.php
https://drone.nextcloud.com/nextcloud/server/35550/10/4

The test have been fixed but the build is still failing. It seems unrelated.
There is now 1 failure in the mariadb10.4-php7.4 test that says:

  1. Test\Share20\DefaultShareProviderTest::testGetSharedWithGroup with data set #0 ('home::shareOwner', 'files/test.txt', 'files/test2.txt')
    Failed asserting that '47' matches expected 0.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1030

Could somebody with more experience have a look (maybe @skjnldsv) ?

@skjnldsv

Copy link
Copy Markdown
Member
  1. Test\Share20\DefaultShareProviderTest::testGetSharedWithGroup with data set #0 ('home::shareOwner', 'files/test.txt', 'files/test2.txt')
    Failed asserting that '47' matches expected 0.

This seems unrelated. Ignore that

@rullzer
rullzer merged commit d602aa1 into nextcloud:masterNov 19, 2020
@welcome

welcomeBot commented Nov 19, 2020

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable20

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share by mail template design issue (logo not centered on the circle) nextcloud logo in email notifications is misaligned in version 20.0.0

4 participants

@medcloud@skjnldsv@MorrisJobke@rullzer