Uh oh!
There was an error while loading. Please reload this page.
Cache all avatar responses - #2416
Merged
Merged
Conversation
mention-bot
commented
Nov 30, 2016
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @MorrisJobke to be potential reviewers. |
nickvergessen
previously requested changes
Nov 30, 2016
| $expires = new \DateTime(); | ||
| $expires->setTimestamp($this->timeFactory->getTime()); | ||
| $expires->add(new \DateInterval('PT30M')); | ||
| $resp->addHeader('Expires', $expires->format(\DateTime::RFC2822)); |
There was a problem hiding this comment.
This is wrong: https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.21'D, d M Y H:i:s T'
MemberAuthor
There was a problem hiding this comment.
Fair enough I'll update. it. But note that 1123 relies on 822 which was replaced by 2822. Anyway will update but the format is the same here I believe.
There was a problem hiding this comment.
The only difference is GMT vs +0000 but I bet one browser will fail on it....
* Cache for 30 minutes * Also cache when avatar can't be found Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
cache_all_avatar_responses
branch
from
November 30, 2016 08:43
dbac9e8 to
5c602f3CompareMorrisJobke
commented
Nov 30, 2016
Member
Tested and headers are set 👍 |
LukasReschke
approved these changes
Dec 1, 2016
LukasReschke
commented
Dec 1, 2016
Member
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already did cache avatars when they were found. However, when browsing for example activities and people that did not yet have avatars we still send a lot of requests to the server.
CC: @LukasReschke@nickvergessen@MorrisJobke