Skip to content

Set frame-ancestors to none if none are filled - #24189

Merged
rullzer merged 1 commit into
masterfrom
enh/csp/frame-ancestors
Nov 18, 2020
Merged

Set frame-ancestors to none if none are filled#24189
rullzer merged 1 commit into
masterfrom
enh/csp/frame-ancestors

Conversation

@rullzer

Copy link
Copy Markdown
Member

frame-ancestors doesn't fall back to default-src. So when we apply a
very restricted CSP we should make sure to set it to 'none' and not
leave it empty.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@juliusknorr

Copy link
Copy Markdown
Member

Seems some tests need adjustments.

@juliusknorrjuliusknorr added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 17, 2020
@rullzer
rullzerforce-pushed the enh/csp/frame-ancestors branch from 04d0357 to 70a3a36CompareNovember 17, 2020 19:21
frame-ancestors doesn't fall back to default-src. So when we apply a
very restricted CSP we should make sure to set it to 'none' and not
leave it empty.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
rullzerforce-pushed the enh/csp/frame-ancestors branch from 70a3a36 to 9163790CompareNovember 18, 2020 09:13
@faily-bot

faily-botBot commented Nov 18, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35668: failure

mysql8.0-php7.4

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Files\ObjectStore\ObjectStoreStorageTest::testMoveOverwrite with data set #1 ('/source.txt', '/target with space.txt')
Expected /target with space.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that false matches expected 'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'.
/drone/src/tests/lib/Files/Storage/Storage.php:222
/drone/src/tests/lib/Files/Storage/Storage.php:277

@rullzerrullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 18, 2020
@rullzer
rullzer merged commit 66013f9 into masterNov 18, 2020
@rullzer
rullzer deleted the enh/csp/frame-ancestors branch November 18, 2020 10:29
@rullzer

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

1 similar comment
@rullzer

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementsecurity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@juliusknorr@nickvergessen