Skip to content

[stable20] Use regex when searching on single file shares - #24239

Merged
rullzer merged 1 commit into
stable20from
backport/24203/stable20
Nov 20, 2020
Merged

[stable20] Use regex when searching on single file shares#24239
rullzer merged 1 commit into
stable20from
backport/24203/stable20

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #24203

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@faily-bot

faily-botBot commented Nov 20, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35726: failure

acceptance-header

  • tests/acceptance/features/header.feature:57
Show full log
 Scenario: search for other users in the contacts menu # /drone/src/tests/acceptance/features/header.feature:57
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
New user button in Users Settings could not be found (NoSuchElementException)
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I create user user1 with password 123456acb # UsersSettingsContext::iCreateUserWithPassword()
And I see that the list of users contains the user user1 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the Contacts menu # ContactsMenuContext::iOpenTheContactsMenu()
And I see that the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
And I see that the contact "user0" in the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
And I see that the contact "user1" in the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
And I see that the Contacts menu search input is shown # ContactsMenuContext::iSeeThatTheContactsMenuSearchInputIsShown()
When I search for the user "user0" # ContactsMenuContext::iSearchForTheUser()
Then I see that the contact "user1" in the Contacts menu is eventually not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsEventuallyNotShown()
And I see that the contact "user0" in the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

@rullzerrullzer added the 3. to review Waiting for reviews label Nov 20, 2020
@rullzer
rullzer merged commit 322b0ab into stable20Nov 20, 2020
@rullzer
rullzer deleted the backport/24203/stable20 branch November 20, 2020 09:15
This was referenced Dec 1, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsperformance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rullzer@ChristophWurst