Skip to content

Use proper methods for display name retrieval - #24318

Merged
ChristophWurst merged 2 commits into
masterfrom
techdebt/noid/remove-oc_user-getDisplayName
Jun 17, 2021
Merged

Use proper methods for display name retrieval#24318
ChristophWurst merged 2 commits into
masterfrom
techdebt/noid/remove-oc_user-getDisplayName

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Nov 23, 2020•
edited
Loading

Copy link
Copy Markdown
Member

@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Nov 23, 2020
@MorrisJobkeMorrisJobke added this to the Nextcloud 21 milestone Nov 23, 2020
blizzz
blizzz approved these changes Nov 23, 2020
View reviewed changes

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

skjnldsv
skjnldsv reviewed Nov 24, 2020
View reviewed changes
Comment threadapps/files_sharing/lib/Cache.php Outdated
skjnldsv
skjnldsv reviewed Nov 24, 2020
View reviewed changes
Comment threadlib/private/TemplateLayout.php
skjnldsv
skjnldsv reviewed Nov 24, 2020
View reviewed changes
Comment threadlib/private/TemplateLayout.php
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 30, 2020
@MorrisJobke

MorrisJobke commented Nov 30, 2020

Copy link
Copy Markdown
MemberAuthor

CI says no ... let me remove the DI part again as it causes a lot of trouble at other places :/

@MorrisJobkeMorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 30, 2020
This was referenced Dec 14, 2020
Merged
Merged
@ChristophWurst

ChristophWurst commented Dec 22, 2020

Copy link
Copy Markdown
Member

tech dept and not fully one -> let's move to 22

@rullzer

rullzer commented Mar 30, 2021

Copy link
Copy Markdown
Member

Kill or continue?

@MorrisJobke

MorrisJobke commented Apr 1, 2021

Copy link
Copy Markdown
MemberAuthor

Kill or continue?

🔥 but the code and not the PR ... let me rebase and 🙏

splitt3r
splitt3r suggested changes Apr 1, 2021
View reviewed changes
Comment threadapps/files_sharing/lib/SharedStorage.php Outdated
@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 1, 2021
@MorrisJobke
MorrisJobkeforce-pushed the techdebt/noid/remove-oc_user-getDisplayName branch from b6d0274 to 22ed863CompareApril 1, 2021 20:48
@nextcloudnextcloud deleted a comment from faily-botBotApr 1, 2021
@MorrisJobke

MorrisJobke commented Apr 1, 2021

Copy link
Copy Markdown
MemberAuthor

Rebased.

@J0WI

J0WI commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

PHPUnit is not happy

This was referenced May 20, 2021
Merged
Merged
@blizzzblizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
@MorrisJobkeMorrisJobke mentioned this pull request Jun 10, 2021
Merged
59 tasks
@blizzzblizzz mentioned this pull request Jun 16, 2021
Merged
45 tasks
@blizzz

blizzz commented Jun 16, 2021

Copy link
Copy Markdown
Member

@MorrisJobke could you check the tests?

@MorrisJobke
Use proper methods for display name retrieval
0954184
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Use DI for files_sharing Cache
2690481
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
MorrisJobkeforce-pushed the techdebt/noid/remove-oc_user-getDisplayName branch from 22ed863 to 2690481CompareJune 17, 2021 08:22
@MorrisJobke

MorrisJobke commented Jun 17, 2021

Copy link
Copy Markdown
MemberAuthor

@MorrisJobke could you check the tests?

Let's see if the latest change fixes it.

@ChristophWurst
ChristophWurst merged commit b73f40e into masterJun 17, 2021
@ChristophWurst
ChristophWurst deleted the techdebt/noid/remove-oc_user-getDisplayName branch June 17, 2021 16:17
@MorrisJobkeMorrisJobke mentioned this pull request Jun 18, 2021
Closed
@blizzzblizzz mentioned this pull request Jun 23, 2021
Merged
39 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@blizzzblizzzblizzz approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@kesselbkesselbAwaiting requested review from kesselb
+1 more reviewer
@splitt3rsplitt3rsplitt3r approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

7 participants

@MorrisJobke@ChristophWurst@rullzer@J0WI@blizzz@splitt3r@skjnldsv