Skip to content

[stable18] Properly encode path when fetching inherited shares - #24388

Merged
MorrisJobke merged 1 commit into
stable18from
backport/24382/stable18
Dec 1, 2020
Merged

[stable18] Properly encode path when fetching inherited shares#24388
MorrisJobke merged 1 commit into
stable18from
backport/24382/stable18

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Nov 26, 2020

Copy link
Copy Markdown

backport of #24382

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/compile amend /

@skjnldsv

Copy link
Copy Markdown
Member

/compile amend /

@rullzerrullzer mentioned this pull request Dec 1, 2020
@MorrisJobke
MorrisJobkeforce-pushed the backport/24382/stable18 branch from 953bb4d to 2a1ec49CompareDecember 1, 2020 13:13
@MorrisJobke

Copy link
Copy Markdown
Member

/compile amend /

@MorrisJobkeMorrisJobke added the 4. to release Ready to be released and/or waiting for tests to finish label Dec 1, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@MorrisJobke
MorrisJobkeforce-pushed the backport/24382/stable18 branch from 348a73b to 81e357eCompareDecember 1, 2020 21:23
@faily-bot

faily-botBot commented Dec 1, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 11: failure

handlebars

sqlite

Show full log
There was 1 error:
1) OCA\Files_Sharing\Tests\ApiTest::testGetShareFromFolderReshares
Error: Call to a member function getMountPoint() on null
/drone/src/lib/private/Share20/Manager.php:305
/drone/src/lib/private/Share20/Manager.php:707
/drone/src/apps/files_sharing/tests/ApiTest.php:653
--
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mysql8.0-php7.2

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Files\Cache\Wrapper\CachePermissionsMaskTest::testBogusPaths with data set #2 ('bogus/', 'bogus')
Failed asserting that 0 is greater than 0.
/drone/src/tests/lib/Files/Cache/CacheTest.php:633

@MorrisJobke
MorrisJobke merged commit ec6a1e8 into stable18Dec 1, 2020
@MorrisJobke
MorrisJobke deleted the backport/24382/stable18 branch December 1, 2020 22:56
@rullzerrullzer mentioned this pull request Dec 7, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@MorrisJobke@ChristophWurst@juliusknorr