Skip to content

Added check on getBackgroundUrl - #24456

Merged
rullzer merged 1 commit into
nextcloud:masterfrom
Aviortheking:patch-1
Dec 1, 2020
Merged

Added check on getBackgroundUrl#24456
rullzer merged 1 commit into
nextcloud:masterfrom
Aviortheking:patch-1

Conversation

@Aviortheking

Copy link
Copy Markdown
Contributor

It crash the Dashboard when the Accessibility module is not present

Fixes#24454

@AviorthekingAviortheking changed the title Added check on window.AccessibilityAdded check on getBackgroundUrlNov 30, 2020
@kesselbkesselb added 3. to review Waiting for reviews bug labels Nov 30, 2020
@kesselb

Copy link
Copy Markdown
Contributor

/compile amend /

It crash the Dashboard when the Accessibility module is not presetn
Signed-off-by: Florian BOUILLON <florian.bouillon@delta-wings.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@MorrisJobkeMorrisJobke added this to the Nextcloud 21 milestone Nov 30, 2020
@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable20

@rullzer
rullzer merged commit dda8395 into nextcloud:masterDec 1, 2020
@welcome

welcomeBot commented Dec 1, 2020

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@Aviortheking
Aviortheking deleted the patch-1 branch December 1, 2020 13:49
@PascalHeynmoeller

PascalHeynmoeller commented Dec 13, 2020

Copy link
Copy Markdown

It crash the Dashboard when the Accessibility module is not present

Fixes #24454

Yes confirmed for 20.0.3, enabling Accessibility App makes new Dashboard to be displayed.

@juliusknorr

Copy link
Copy Markdown
Member

Related patch for stable20 #24636

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard don't works with Accessibility module not enabled

6 participants

@Aviortheking@kesselb@MorrisJobke@PascalHeynmoeller@juliusknorr@rullzer