Uh oh!
There was an error while loading. Please reload this page.
Bump icewind/streams from 0.7.1 to 0.7.2 - #24533
Conversation
d36da7e to
17fa2a3CompareMorrisJobke
commented
Dec 3, 2020
Psalm is not happy :( |
ChristophWurst
commented
Dec 3, 2020
Over method overwrites like @icewind1991 could you take care? I think you understand the changes best ✌️ |
2135f8b to
76c17a4Comparerullzer
commented
Dec 4, 2020
I think a lot of the psalm warnings here come because there are also a lot of fixes. So I think we actually had most in there already they are just slighyly modified. The changes in streams itself are minimal. @MorrisJobke can you rerun psalm? Then I vote to just get it in. |
ChristophWurst
commented
Dec 4, 2020
we should fix those |
MorrisJobke
commented
Dec 4, 2020
Yep - Ping me again once they are in. |
nickvergessen
commented
Dec 7, 2020
Can we move this forward? It's currently blocking #24486 which needs a bump of 3rdparty to get the phonenumber lib in. Or we can also unmerge the stream update until tests are ready, but we should get master unblocked soon! |
nickvergessen
commented
Dec 7, 2020
Revert is in nextcloud/3rdparty#546 |
ChristophWurst
commented
Dec 18, 2020
oudated |
ChristophWurst
commented
Dec 18, 2020
let's keep it open for 22. but we need to redo the bump in 3rdparty |
0d87b00 to
8e77dc2CompareChristophWurst
commented
Dec 28, 2020
Neat, CI passes. |
14b7f51 to
6a0d175Compare6a0d175 to
4747205Comparef33edbe to
b9f8622CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
b9f8622 to
aa41b9aCompareSigned-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
aa41b9a to
73c7d0dCompare
Uh oh!
There was an error while loading. Please reload this page.