Skip to content

[stable20] Don't log params of imagecreatefromstring - #24546

Merged
rullzer merged 1 commit into
stable20from
backport/24543/stable20
Dec 15, 2020
Merged

[stable20] Don't log params of imagecreatefromstring#24546
rullzer merged 1 commit into
stable20from
backport/24543/stable20

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Dec 4, 2020

Copy link
Copy Markdown

backport of #24543

@PVince81@backportbot
Don't log params of imagecreatefromstring
d4d009f
To prevent flooding the log with actual image data.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 20.0.3 milestone Dec 4, 2020
MorrisJobke
MorrisJobke previously requested changes Dec 4, 2020
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for 20.0.3 being out

@faily-bot

faily-botBot commented Dec 4, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 188: failure

mysql8.0-php7.2

Show full log
There were 3 errors:
1) OCA\Files\Tests\BackgroundJob\DeleteOrphanedItemsJobTest::testClearUserTagMappings
Doctrine\DBAL\Exception\UniqueConstraintViolationException: An exception occurred while executing 'INSERT INTO `oc_filecache` (`storage`, `path`, `path_hash`) VALUES(?, ?, ?)' with params [1337, "apps\/files\/tests\/deleteorphanedtagsjobtest.php", "4cc42159b8d10b8a7295624bae65759f"]:
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'oc_filecache.fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:55
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:169
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:149
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1071
/drone/src/lib/private/DB/Connection.php:222
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:124
Caused by
Doctrine\DBAL\Driver\PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'oc_filecache.fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:129
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1062
/drone/src/lib/private/DB/Connection.php:222
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:124
Caused by
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'oc_filecache.fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:127
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1062
/drone/src/lib/private/DB/Connection.php:222
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:124
2) OCA\Files\Tests\BackgroundJob\DeleteOrphanedItemsJobTest::testClearComments
Doctrine\DBAL\Exception\UniqueConstraintViolationException: An exception occurred while executing 'INSERT INTO `oc_filecache` (`storage`, `path`, `path_hash`) VALUES(?, ?, ?)' with params [1337, "apps\/files\/tests\/deleteorphanedtagsjobtest.php", "4cc42159b8d10b8a7295624bae65759f"]:
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'oc_filecache.fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:55
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:169
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:149
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1071
/drone/src/lib/private/DB/Connection.php:222
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:173
Caused by
Doctrine\DBAL\Driver\PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'oc_filecache.fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:129
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1062
/drone/src/lib/private/DB/Connection.php:222
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:173
Caused by
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'oc_filecache.fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:127
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1062
/drone/src/lib/private/DB/Connection.php:222
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:173
3) OCA\Files\Tests\BackgroundJob\DeleteOrphanedItemsJobTest::testClearCommentReadMarks
Doctrine\DBAL\Exception\UniqueConstraintViolationException: An exception occurred while executing 'INSERT INTO `oc_filecache` (`storage`, `path`, `path_hash`) VALUES(?, ?, ?)' with params [1337, "apps\/files\/tests\/deleteorphanedtagsjobtest.php", "4cc42159b8d10b8a7295624bae65759f"]:
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'oc_filecache.fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:55
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:169
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:149
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1071
/drone/src/lib/private/DB/Connection.php:222
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:224
Caused by
Doctrine\DBAL\Driver\PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'oc_filecache.fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:129
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1062
/drone/src/lib/private/DB/Connection.php:222
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:224
Caused by
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'oc_filecache.fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:127
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1062
/drone/src/lib/private/DB/Connection.php:222
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:224
--
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) OCA\Files\Tests\BackgroundJob\DeleteOrphanedItemsJobTest::testClearSystemTagMappings
Failed asserting that actual size 0 matches expected size 1.
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:103

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Dec 4, 2020
@rullzerrullzer mentioned this pull request Dec 14, 2020
Merged
@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 15, 2020
@rullzer
rullzer merged commit 9305a00 into stable20Dec 15, 2020
@rullzer
rullzer deleted the backport/24543/stable20 branch December 15, 2020 15:36
@rullzerrullzer mentioned this pull request Jan 5, 2021
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@PVince81PVince81Awaiting requested review from PVince81
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 20.0.5

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@MorrisJobke@juliusknorr@PVince81