Skip to content

[stable20] use storage copy implementation when doing dav copy - #24590

Merged
MorrisJobke merged 1 commit into
stable20from
backport/24358/stable20
Jan 7, 2021
Merged

[stable20] use storage copy implementation when doing dav copy#24590
MorrisJobke merged 1 commit into
stable20from
backport/24358/stable20

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Dec 7, 2020

Copy link
Copy Markdown

backport of #24358

@icewind1991@backportbot
use storage copy implementation when doing dav copy
6790369
instead of using the sabredav fallback (which does a read+write stream copy)
this greatly speeds up dav copies
Signed-off-by: Robin Appelman <robin@icewind.nl>
@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 20.0.3 milestone Dec 7, 2020
@faily-bot

faily-botBot commented Dec 7, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 276: failure

mysql5.6-php7.2

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Files\Cache\Wrapper\CachePermissionsMaskTest::testSearchQueryByTag
Failed asserting that 2 matches expected 3.
/drone/src/tests/lib/Files/Cache/CacheTest.php:363

@rullzerrullzer mentioned this pull request Dec 7, 2020
Merged
@rullzerrullzer mentioned this pull request Dec 14, 2020
Merged
@rullzerrullzer added the 3. to review Waiting for reviews label Dec 15, 2020
@rullzerrullzer mentioned this pull request Jan 5, 2021
Merged
1 task
MorrisJobke
MorrisJobke approved these changes Jan 7, 2021
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke
MorrisJobke merged commit 8295cc9 into stable20Jan 7, 2021
@MorrisJobke
MorrisJobke deleted the backport/24358/stable20 branch January 7, 2021 13:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@icewind1991icewind1991Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsperformance 🚀

Projects

None yet

Milestone

Nextcloud 20.0.5

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@icewind1991