Uh oh!
There was an error while loading. Please reload this page.
Indicate preview availability in recent file api responses - #24643
Merged
Conversation
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3inyforce-pushed
the
fix/noid/recent-files-has-preview
branch
from
December 10, 2020 15:38
86851a4 to
f56eb82Comparest3iny
marked this pull request as ready for review
December 10, 2020 16:34
skjnldsv
approved these changes
Dec 11, 2020
juliusknorr
approved these changes
Dec 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #23350, #14849
The recent files list also has ugly borders when there is no preview available. I fixed this by adding the boolean
hasPreviewto responses from the recent files api.Before
After