Uh oh!
There was an error while loading. Please reload this page.
dont offer to edit external config settings if we can't edit them - #24661
Merged
Conversation
rullzer
approved these changes
Dec 14, 2020
juliusknorrforce-pushed
the
external-storage-cant-edit
branch
from
December 28, 2020 11:20
9df23d2 to
ce45787Comparejuliusknorr
commented
Dec 28, 2020
Member
Rebased and pushed a fix for the tests |
juliusknorrforce-pushed
the
external-storage-cant-edit
branch
from
December 28, 2020 11:48
ce45787 to
2c669dbComparejuliusknorr
approved these changes
Dec 28, 2020
juliusknorrforce-pushed
the
external-storage-cant-edit
branch
from
December 28, 2020 12:16
2c669db to
2e94b3dCompareUh oh!
There was an error while loading. Please reload this page.
MorrisJobke
commented
Jan 7, 2021
Member
CI fails. |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
external-storage-cant-edit
branch
from
January 8, 2021 14:07
be163c5 to
518e91bCompareSigned-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
commented
Jan 8, 2021
MemberAuthor
CI is happy (except for our scheduled mysql test timeout) |
MorrisJobke
approved these changes
Jan 11, 2021
icewind1991
commented
Jan 14, 2021
MemberAuthor
/backport to stable20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no need to confuse the user by providing options that he cant use.