Uh oh!
There was an error while loading. Please reload this page.
enables the file name check also to match name of mountpoints - #24703
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
nickvergessen
approved these changes
Dec 15, 2020
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
nickvergessen
approved these changes
Dec 15, 2020
blizzz
commented
Dec 18, 2020
MemberAuthor
/backport to stable20 |
blizzz
commented
Dec 18, 2020
MemberAuthor
/backport to stabl19 |
blizzz
commented
Dec 18, 2020
MemberAuthor
/backport to stable18 |
The backport to stabl19 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you have an external storage configured, you can assign tags to it as well. The file name checker of the workflow engine could not do so, because the filename is technically empty, instead we have a mountpoint name.
Thus, if we receive an empty file and identify an external storage, we return the name of the mountpoint, unless it is mounted as user home (
/).