Skip to content

[stable20] fixes sharing to group ids with characters that are being url encoded - #24763

Merged
blizzz merged 3 commits into
stable20from
backport/24515/stable20
Jan 5, 2021
Merged

[stable20] fixes sharing to group ids with characters that are being url encoded#24763
blizzz merged 3 commits into
stable20from
backport/24515/stable20

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Dec 18, 2020

Copy link
Copy Markdown

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #24515

@rullzerrullzer added the 3. to review Waiting for reviews label Dec 28, 2020
@rullzer

Copy link
Copy Markdown
Member

@blizzz mind to check the conflicts?

@rullzerrullzer mentioned this pull request Jan 5, 2021
1 task
@blizzz

blizzz commented Jan 5, 2021

Copy link
Copy Markdown
Member

@blizzz mind to check the conflicts?

due to a style issue. fixed.

@blizzz
blizzzforce-pushed the backport/24515/stable20 branch from f17581a to 3ba1eb7CompareJanuary 5, 2021 17:47
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzzforce-pushed the backport/24515/stable20 branch from 3ba1eb7 to f342021CompareJanuary 5, 2021 17:54
@blizzzblizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 5, 2021
@faily-bot

faily-botBot commented Jan 5, 2021

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 996: failure

acceptance-users

  • tests/acceptance/features/users.feature:47
Show full log
 Scenario: users navigation without disabled users # /drone/src/tests/acceptance/features/users.feature:47
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
And I see that the list of users contains the user disabledUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user disabledUser # UsersSettingsContext::iOpenTheActionsMenuOf()
Row for user disabledUser in Users Settings could not be found
Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
When I click the "Enable user" action in the disabledUser actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()
When I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()

@blizzz
blizzz merged commit 25143fc into stable20Jan 5, 2021
@blizzz
blizzz deleted the backport/24515/stable20 branch January 5, 2021 22:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@blizzz@skjnldsv