Skip to content

Drop all dead packages - #24816

Merged
juliusknorr merged 1 commit into
masterfrom
techdept/dead-packages
Dec 23, 2020
Merged

Drop all dead packages#24816
juliusknorr merged 1 commit into
masterfrom
techdept/dead-packages

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Dec 22, 2020

Copy link
Copy Markdown
Member

Apparently we have plenty of leftover of previous sub-dependencies.
Composer automatically dumps those with any future dependency update, so
I'm dropping them in an atomic step.

@ChristophWurstChristophWurst added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Dec 22, 2020
@ChristophWurstChristophWurst added this to the Nextcloud 21 milestone Dec 22, 2020
@ChristophWurstChristophWurst self-assigned this Dec 22, 2020
@ChristophWurst

This comment has been minimized.

@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

The only code where we use the dead packages is the ring exception handling introduced with #7450. @rullzer if the ring thingy isn't even used I guess we can undo the specific exception handling, right?

Apparently we have plenty of leftover of previous sub-dependencies.
Composer automatically dumps those with any future dependency update, so
I'm dropping them in an atomic step.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@rullzerrullzer mentioned this pull request Dec 23, 2020
39 tasks
@juliusknorr
juliusknorr merged commit 5b61120 into masterDec 23, 2020
@juliusknorr
juliusknorr deleted the techdept/dead-packages branch December 23, 2020 13:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristophWurst@rullzer@juliusknorr