Skip to content

Cleanup bundle files before checking the rebuild - #24865

Merged
rullzer merged 1 commit into
masterfrom
tests/node-build-clean
Dec 29, 2020
Merged

Cleanup bundle files before checking the rebuild#24865
rullzer merged 1 commit into
masterfrom
tests/node-build-clean

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

After a6d343b we ended up with having lots of unused chunks in the settings app. We should in addition to the regular build clean up the previous chunks to make sure that those leftovers will be catched by CI as well.

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Tests should fail and be happy again after #24772

@rullzer

Copy link
Copy Markdown
Member

Tests should fail and be happy again after #24772

Don't seem to fail

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

There we go https://github.com/nextcloud/server/pull/24865/checks?check_run_id=1620792109 I picked the wrong makefile target that runs the checkout after removing the files 🙈

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@faily-bot

faily-botBot commented Dec 29, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 797: failure

postgres9-php7.3

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\User\DatabaseTest::testSearch
Failed asserting that actual size 3 matches expected size 2.
/drone/src/tests/lib/User/Backend.php:114
/drone/src/tests/lib/User/DatabaseTest.php:125

@juliusknorrjuliusknorr added the 3. to review Waiting for reviews label Dec 29, 2020
@juliusknorrjuliusknorr added this to the Nextcloud 21 milestone Dec 29, 2020
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Rebased, relevant tests are happy

@rullzer
rullzer merged commit 4c01f0d into masterDec 29, 2020
@rullzer
rullzer deleted the tests/node-build-clean branch December 29, 2020 14:46
@rullzerrullzer mentioned this pull request Dec 30, 2020
39 tasks
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@PVince81

Copy link
Copy Markdown
Member

backport to stable20 is here: #25504

I checked stable21 and it already has the change.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr@rullzer@PVince81@ChristophWurst@MorrisJobke