Skip to content

ReplyTo option for sharebymail Issue #24139 - #24978

Merged
skjnldsv merged 4 commits into
nextcloud:masterfrom
dems54:issue24139
Feb 19, 2021
Merged

ReplyTo option for sharebymail Issue #24139#24978
skjnldsv merged 4 commits into
nextcloud:masterfrom
dems54:issue24139

Conversation

@dems54

@dems54dems54 commented Jan 5, 2021•
edited by skjnldsv
Loading

Copy link
Copy Markdown
Contributor

Should let users decide if anwsers to be sent to their account email, or to nextcloud server email

fix#24139

@dems54dems54 changed the title Reply to option for sharebymail Issue #24139ReplyTo option for sharebymail Issue #24139Jan 5, 2021
@dems54
dems54force-pushed the issue24139 branch 2 times, most recently from 3d2919b to 5dc9fa3CompareJanuary 8, 2021 00:23
@dems54

dems54 commented Jan 11, 2021

Copy link
Copy Markdown
ContributorAuthor

For review please : @skjnldsv@rullzer@ChristophWurst@juliushaertl

(I hope this is the right way to ask for reviewers, this is my first PR, many thanks 🙂)

@skjnldsvskjnldsv added this to the Nextcloud 22 milestone Jan 12, 2021
@skjnldsv

skjnldsv commented Jan 12, 2021

Copy link
Copy Markdown
Member

Hey! Thanks :)
Can you rebase and squash your commits into one?

juliusknorr
juliusknorr reviewed Jan 12, 2021
View reviewed changes
Comment threadapps/sharebymail/lib/Settings/SettingsManager.php Outdated
juliusknorr
juliusknorr reviewed Jan 12, 2021
View reviewed changes
Comment threadapps/sharebymail/lib/Settings/SettingsManager.php Outdated
juliusknorr
juliusknorr approved these changes Jan 12, 2021
View reviewed changes

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks, otherwise fine by me 👍

@dems54

dems54 commented Jan 12, 2021

Copy link
Copy Markdown
ContributorAuthor

Hey! Thanks :)
Can you rebase and squash your commits into one?

Rebase and squash are OK.
But I don't know why Static Code Analysis is now NOK ? It doesn't seem to relate to my commit...

@dems54

dems54 commented Jan 12, 2021

Copy link
Copy Markdown
ContributorAuthor

Small nitpicks, otherwise fine by me 👍

Good suggestions.
This is my first PR : who must validte your propositions ?

@skjnldsv

skjnldsv commented Jan 12, 2021

Copy link
Copy Markdown
Member

But I don't know why Static Code Analysis is now NOK ? It doesn't seem to relate to my commit...

No, it doesn't indeed. Just ignore

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 27, 2021
rullzer
rullzer requested changes Jan 27, 2021
View reviewed changes
Comment threadapps/sharebymail/lib/Settings/SettingsManager.php Outdated
@dems54
dems54 requested a review from rullzerJanuary 27, 2021 21:33
@dems54

dems54 commented Jan 27, 2021

Copy link
Copy Markdown
ContributorAuthor

Possible to merge this PR in NC20 or NC21 ?

dems54and others added 3 commits January 28, 2021 15:57
@dems54
ReplyTo option for sharebymail Issuenextcloud#24139
4ac636d
Signed-off-by: Nicolas SIMIDE <2083596+dems54@users.noreply.github.com>
@dems54@juliusknorr
Update apps/sharebymail/lib/Settings/SettingsManager.php
0a8d934
Small nitpicks
Co-authored-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Nicolas SIMIDE <2083596+dems54@users.noreply.github.com>
@dems54@juliusknorr
Update apps/sharebymail/lib/Settings/SettingsManager.php
1427a9a
Small nitpicks
Co-authored-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Nicolas SIMIDE <2083596+dems54@users.noreply.github.com>
@dems54
ReplyTo option for sharebymail - Issuenextcloud#24139- Little bug fix
69bf0c8
Signed-off-by: Nicolas SIMIDE <2083596+dems54@users.noreply.github.com>
@dems54

dems54 commented Feb 18, 2021

Copy link
Copy Markdown
ContributorAuthor

@rullzer it's ok for you ?

@skjnldsv
skjnldsv merged commit 9464308 into nextcloud:masterFeb 19, 2021
@welcome

welcomeBot commented Feb 19, 2021

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@skjnldsv

skjnldsv commented Feb 19, 2021

Copy link
Copy Markdown
Member

NC22

This was referenced Feb 25, 2021
Merged
Closed
This was referenced Mar 22, 2021
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: emailsfeature: sharing

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

[sharebymail] Should let users decide if anwsers to be sent to their account email, or to nextcloud server email

5 participants

@dems54@skjnldsv@rullzer@juliusknorr@ChristophWurst