Uh oh!
There was an error while loading. Please reload this page.
Add setup check to verify that the used DB version is still supported… - #25016
Conversation
ba0724b to
efde9a7CompareMorrisJobke
commented
Jan 7, 2021
| public function check() { | ||
| switch (get_class($this->connection->getDatabasePlatform())) { | ||
| case MySQL80Platform::class: # extends MySQL57Platform |
There was a problem hiding this comment.
I left all the platforms in here to have the full overview (except DB2 or MSSQLServer as we don't support them at all)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ff94601 to
58adf13CompareMorrisJobke
commented
Jan 7, 2021
Ready for review :) |
58adf13 to
834d8a5CompareMorrisJobke
commented
Jan 7, 2021
/backport to stable20 |
| $version = strtolower($row['Value']); | ||
| if (strpos($version, 'mariadb') !== false) { | ||
| if (version_compare($version, '10.4', '<')) { |
There was a problem hiding this comment.
| if (version_compare($version, '10.4', '<')) { | |
| if (version_compare($version, '10.2', '<')) { |
There was a problem hiding this comment.
But 10.4 is the mysql8 compatible version?
Ref https://github.com/nextcloud/server/blob/stable16/lib/private/Setup/MySQL.php#L48-L56
There was a problem hiding this comment.
Our docs say, that 10.2 works and CI runs against 10.1 🙈
There was a problem hiding this comment.
I changed it to 10.2 for now. We can raise it later again, okay?
… in the next major release Signed-off-by: Morris Jobke <hey@morrisjobke.de>
834d8a5 to
bffa61fCompareMorrisJobke
commented
Jan 11, 2021
@rullzer@ChristophWurst Ready for review :) |
… in the next major release