Uh oh!
There was an error while loading. Please reload this page.
Don't try a transaction for the migrator on MySQL - #25038
Merged
Conversation
As per https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html CREATE TABLE statements automatically commit always. The only reason this worked in the past was that PHPs PDO connection didn't check the actual state on commit, but only checked their internal state. But in PHP8 this was fixed: https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L446-L450 So now commit() fails because the internal PDO connection implicitly commited already. Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
ChristophWurst, juliusknorr, kesselb and rullzerJanuary 8, 2021 15:33
ChristophWurst
approved these changes
Jan 8, 2021
ChristophWurst
approved these changes
Jan 8, 2021
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Proof is at nextcloud/mail#4319
3 tasks
blizzz
approved these changes
Jan 8, 2021
blizzz
left a comment
Member
There was a problem hiding this comment.
had successful CI runs as well, against both 7.4 and 8.0
rullzer
commented
Jan 11, 2021
Member
But CI says no https://drone.nextcloud.com/nextcloud/server/1195/11/5 |
Signed-off-by: Joas Schilling <coding@schilljs.com>
ChristophWurst
approved these changes
Jan 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html
CREATE TABLE statements automatically commit always. The only reason
this worked in the past was that PHPs PDO connection didn't check the
actual state on commit, but only checked their internal state.
But in PHP8 this was fixed:
https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L446-L450
So now commit() fails because the internal PDO connection implicitly
commited already.