Uh oh!
There was an error while loading. Please reload this page.
Remove unneeded casts that were found by Psalm - #25073
Merged
Merged
Conversation
MorrisJobke
requested review from
ChristophWurst, kesselb, rullzer and skjnldsvJanuary 11, 2021 12:02
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see #24521) Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobkeforce-pushed
the
psalm/24521/remove-unneeded-casts
branch
from
January 11, 2021 12:14
31ca28d to
24d436cCompareChristophWurst
approved these changes
Jan 11, 2021
kesselb
approved these changes
Jan 11, 2021
| $index = $index + 1; | ||
| $x = (int) 1; | ||
| $x = 1; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see #24521)
This is basically a split from the above PR to isolate the problem in that PR.