Skip to content

extend ILDAPProvider to allow reading arbitrairy ldap attributes for users - #25128

Merged
blizzz merged 2 commits into
masterfrom
ldapprovider-get-property
Jan 22, 2021
Merged

extend ILDAPProvider to allow reading arbitrairy ldap attributes for users#25128
blizzz merged 2 commits into
masterfrom
ldapprovider-get-property

Conversation

@icewind1991

@icewind1991icewind1991 commented Jan 14, 2021

Copy link
Copy Markdown
Member

For allowing things like #24955 using public interfaces

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Jan 14, 2021
@icewind1991icewind1991 added this to the Nextcloud 22 milestone Jan 14, 2021
blizzz
blizzz requested changes Jan 14, 2021
View reviewed changes
Comment threadlib/public/LDAP/ILDAPProvider.php Outdated
Comment threadapps/user_ldap/lib/LDAPProvider.php Outdated
@icewind1991
extend ILDAPProvider to allow reading arbitrairy ldap attributes for …
fdc8635
…users
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the ldapprovider-get-property branch from 5ba53d7 to fdc8635CompareJanuary 19, 2021 15:34
@icewind1991

icewind1991 commented Jan 19, 2021

Copy link
Copy Markdown
MemberAuthor

@blizzz done

MorrisJobke
MorrisJobke reviewed Jan 22, 2021
View reviewed changes
Comment threadlib/public/LDAP/ILDAPProvider.php Outdated
MorrisJobke
MorrisJobke approved these changes Jan 22, 2021
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but some tests would be nice.

@MorrisJobke

MorrisJobke commented Jan 22, 2021

Copy link
Copy Markdown
Member

/backport to stable20

@blizzz@MorrisJobke
adjust since
f15148f
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Co-authored-by: Morris Jobke <hey@morrisjobke.de>
@blizzz
blizzz merged commit 9394333 into masterJan 22, 2021
@blizzz
blizzz deleted the ldapprovider-get-property branch January 22, 2021 13:31
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jan 22, 2021
Merged
@rullzerrullzer mentioned this pull request Jan 22, 2021
Merged
19 tasks
@MorrisJobke

MorrisJobke commented Jan 22, 2021

Copy link
Copy Markdown
Member

For allowing things like #24955 using public interfaces

Mind to submit this with the new API?

@MorrisJobke

MorrisJobke commented Jan 22, 2021

Copy link
Copy Markdown
Member

Mind to submit this with the new API?

cc @blizzz@icewind1991

@MorrisJobke

MorrisJobke commented Mar 29, 2021

Copy link
Copy Markdown
Member

For allowing things like #24955 using public interfaces

Mind to submit this with the new API?

@blizzz@icewind1991 Any news here?

@blizzz

blizzz commented Mar 29, 2021

Copy link
Copy Markdown
Member

Last was #25010 (comment)

@icewind1991

icewind1991 commented Mar 31, 2021

Copy link
Copy Markdown
MemberAuthor

#26397

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@blizzzblizzzblizzz approved these changes
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@MorrisJobke@blizzz