Skip to content

Fix @nextcloud/vue imports - #25131

Merged
rullzer merged 1 commit into
masterfrom
fix/imports
Jan 14, 2021
Merged

Fix @nextcloud/vue imports#25131
rullzer merged 1 commit into
masterfrom
fix/imports

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jan 14, 2021

Copy link
Copy Markdown
Member

Reduce the size by a lot!

Hash: de4f1b92c36390c99e86
Version: webpack 4.45.0
Time: 5384ms
Built at: 2021-01-14 17:10:46
Asset Size Chunks Chunk Names
dashboard.js 3.35 MiB main [emitted] main
dashboard.js.map 3.3 MiB main [emitted] [dev] main
Entrypoint main = dashboard.js dashboard.js.map
--- VS ---
Hash: 40bbdf3197497f22f601
Version: webpack 4.45.0
Time: 460ms
Built at: 2021-01-14 17:10:59
Asset Size Chunks Chunk Names
dashboard.js 1.51 MiB main [emitted] main
dashboard.js.map 1.62 MiB main [emitted] [dev] main
Entrypoint main = dashboard.js dashboard.js.map

@skjnldsvskjnldsv self-assigned this Jan 14, 2021
@skjnldsvskjnldsv added this to the Nextcloud 21 milestone Jan 14, 2021
@skjnldsv
Fix @nextcloud/vue imports
428907c
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
ChristophWurst
ChristophWurst approved these changes Jan 14, 2021
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 💨

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 14, 2021
@rullzer
rullzer merged commit 801c691 into masterJan 14, 2021
@rullzer
rullzer deleted the fix/imports branch January 14, 2021 18:08
@rullzerrullzer mentioned this pull request Jan 15, 2021
Merged
15 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@julien-ncjulien-ncjulien-nc approved these changes

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementjavascript

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv@rullzer@ChristophWurst@juliusknorr@julien-nc