Skip to content

do cachejail search filtering in sql - #25136

Merged
PVince81 merged 5 commits into
masterfrom
cachejail-search-filter
Mar 15, 2021
Merged

do cachejail search filtering in sql#25136
PVince81 merged 5 commits into
masterfrom
cachejail-search-filter

Conversation

@icewind1991

@icewind1991icewind1991 commented Jan 14, 2021

Copy link
Copy Markdown
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Jan 14, 2021
@icewind1991icewind1991 added this to the Nextcloud 22 milestone Jan 14, 2021
@nextcloudnextcloud deleted a comment from faily-botBotJan 19, 2021
@icewind1991
icewind1991force-pushed the cachejail-search-filter branch 2 times, most recently from 052644e to 03ddc59CompareJanuary 25, 2021 13:25
@nextcloudnextcloud deleted a comment from faily-botBotJan 25, 2021
@icewind1991
icewind1991force-pushed the cachejail-search-filter branch 2 times, most recently from fb8ea61 to 4044fe7CompareJanuary 25, 2021 14:40
@rullzer

rullzer commented Jan 26, 2021

Copy link
Copy Markdown
Member

CI is not happy

@icewind1991
do cachejail search filtering in sql
a44aab1
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix cachjail searching for root
27f9df2
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix search in nested jails
5ae0be0
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the cachejail-search-filter branch from 048862a to 2453ae3CompareJanuary 26, 2021 14:50
@icewind1991
adjust tests
e511a53
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the cachejail-search-filter branch 2 times, most recently from 575fd14 to 4f7d650CompareJanuary 26, 2021 15:12
@icewind1991
only use share cacheentry when available
6ecf33b
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the cachejail-search-filter branch from 4f7d650 to 6ecf33bCompareJanuary 26, 2021 15:22
@icewind1991

icewind1991 commented Jan 26, 2021

Copy link
Copy Markdown
MemberAuthor

Ci is happy

@icewind1991icewind1991 mentioned this pull request Jan 26, 2021
Closed
@wiswedel

wiswedel commented Jan 26, 2021

Copy link
Copy Markdown
Contributor

@icewind1991 To what data extent has this been tested? What grade of performance improvement does it guarantee?

@icewind1991

icewind1991 commented Jan 27, 2021

Copy link
Copy Markdown
MemberAuthor

The improvement this will make is massively depended on setup and usage details, trying to give any number would be completely meaningless.

@jospoortvliet

jospoortvliet commented Jan 27, 2021

Copy link
Copy Markdown
Member

The improvement this will make is massively depended on setup and usage details, trying to give any number would be completely meaningless.

how much faster will it make getting the results of files on our instance? That'd be one concrete case 🚀

@rullzer

rullzer commented Jan 27, 2021

Copy link
Copy Markdown
Member

The improvement this will make is massively depended on setup and usage details, trying to give any number would be completely meaningless.

how much faster will it make getting the results of files on our instance? That'd be one concrete case rocket

it will make it 9 faster (not 9x just 9).

On a more serious note. We will know once we measure it. But don't expect that all of sudden everything flies. But it helps.

@icewind1991

icewind1991 commented Mar 10, 2021

Copy link
Copy Markdown
MemberAuthor

ping @juliushaertl

PVince81
PVince81 approved these changes Mar 15, 2021
View reviewed changes

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 see minor comment

Comment threadlib/private/Files/Cache/Wrapper/CacheJail.php
Comment threadlib/private/Files/Cache/Wrapper/CacheJail.php
@PVince81
PVince81 merged commit e559afb into masterMar 15, 2021
@PVince81
PVince81 deleted the cachejail-search-filter branch March 15, 2021 16:45
@icewind1991

icewind1991 commented Mar 15, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@icewind1991

icewind1991 commented Mar 15, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@icewind1991

icewind1991 commented Mar 15, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

This was referenced Mar 15, 2021
Merged
Merged
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Mar 15, 2021
Merged
@icewind1991icewind1991 mentioned this pull request Mar 17, 2021
Closed
@jknockaertjknockaert mentioned this pull request Apr 14, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81PVince81PVince81 approved these changes
@rullzerrullzerrullzer approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@rullzer@wiswedel@jospoortvliet@PVince81