Skip to content

Do not redirect to logout after login - #25142

Merged
rullzer merged 1 commit into
masterfrom
fix/login_no_logout_redirect
Jan 15, 2021
Merged

Do not redirect to logout after login#25142
rullzer merged 1 commit into
masterfrom
fix/login_no_logout_redirect

Conversation

@rullzer

Copy link
Copy Markdown
Member

This can happen when the session was killed due to a timeout. Then
logout was triggered. Nobody wants to login only to be logged out again.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

This can happen when the session was killed due to a timeout. Then
logout was triggered. Nobody wants to login only to be logged out again.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 15, 2021
@faily-bot

faily-botBot commented Jan 15, 2021

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1375: failure

acceptance-users

  • tests/acceptance/features/users.feature:47
Show full log
 Scenario: users navigation without disabled users # /drone/src/tests/acceptance/features/users.feature:47
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
And I see that the list of users contains the user disabledUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user disabledUser # UsersSettingsContext::iOpenTheActionsMenuOf()
Row for user disabledUser in Users Settings could not be found
Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
When I click the "Enable user" action in the disabledUser actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()
When I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()

@rullzer
rullzer merged commit d3ab26c into masterJan 15, 2021
@rullzer
rullzer deleted the fix/login_no_logout_redirect branch January 15, 2021 10:51
@rullzer

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@rullzer

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@MorrisJobke@ChristophWurst@juliusknorr