Skip to content

Add support for webp - #25173

Merged
rullzer merged 1 commit into
masterfrom
enh/webp_support
Jan 19, 2021
Merged

Add support for webp#25173
rullzer merged 1 commit into
masterfrom
enh/webp_support

Conversation

@rullzer

Copy link
Copy Markdown
Member

Including handling in OC_Image
But also a preview provider

Of course only works if your php actually supports webp

Most useful feature of the release as it allow sharing webp memes and getting a proper preview for it.

@rullzerrullzer changed the title Add support for webp\Add support for webpJan 18, 2021
@juliusknorr

Copy link
Copy Markdown
Member

Psalm is not happy:

/home/runner/work/server/server/lib/private/PreviewManager.php:317:4:error - UndefinedClass: Class or interface OC\Preview\WebP does not exist
/home/runner/work/server/server/lib/private/PreviewManager.php:364:31:error - UndefinedClass: Class or interface OC\Preview\WebP does not exist
/home/runner/work/server/server/lib/private/legacy/OC_Image.php:645:120:error - InvalidScalarArgument: Argument 1 of OC\Files

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great if you actually added the webp class to git :)

@rullzer

Copy link
Copy Markdown
MemberAuthor

would be great if you actually added the webp class to git :)

mimimi

Including handling in OC_Image
But also a preview provider
Of course only works if your php actually supports webp
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@faily-bot

faily-botBot commented Jan 19, 2021

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1494: failure

acceptance-users

  • tests/acceptance/features/users.feature:47
Show full log
 Scenario: users navigation without disabled users # /drone/src/tests/acceptance/features/users.feature:47
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
And I see that the list of users contains the user disabledUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user disabledUser # UsersSettingsContext::iOpenTheActionsMenuOf()
Row for user disabledUser in Users Settings could not be found
Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
When I click the "Enable user" action in the disabledUser actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()
When I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()

@rullzer
rullzer merged commit 3658d83 into masterJan 19, 2021
@rullzer
rullzer deleted the enh/webp_support branch January 19, 2021 20:01
@rullzerrullzer mentioned this pull request Jan 21, 2021
15 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@juliusknorr@MorrisJobke@ChristophWurst