Skip to content

Readd element ID after component mount. - #25182

Merged
skjnldsv merged 1 commit into
masterfrom
bugfix/noid/readd-element-id
Jan 18, 2021
Merged

Readd element ID after component mount.#25182
skjnldsv merged 1 commit into
masterfrom
bugfix/noid/readd-element-id

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Me:

I think I just found out why Notifications bell is always missing after hybernate.
document.getElementById('unified-search') returns null after initial mount. and aparently the id from

<HeaderMenu id="unified-search"
is not being set on the element.
I guess because HeaderMenu has an id prop and is not setting it itself anymore:
id: {
type:String,
required:true,
},

Can I just fix it in HeaderMenu by id="id"

@skjnldsv

of course :)

While now I think it's not fixing it, we should still make sure the id from

<div id="unified-search"></div>
should remain

Comment threadcore/src/components/HeaderMenu.vue Outdated
Signed-off-by: Joas Schilling <coding@schilljs.com>
@skjnldsv
skjnldsv merged commit 0ddcf0a into masterJan 18, 2021
@skjnldsv
skjnldsv deleted the bugfix/noid/readd-element-id branch January 18, 2021 20:08
@rullzerrullzer mentioned this pull request Jan 19, 2021
15 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@ChristophWurst@skjnldsv