Skip to content

Directly add notifications element - #25184

Merged
rullzer merged 1 commit into
masterfrom
feature/noid/first-class-citizen-notifications
Jan 19, 2021
Merged

Directly add notifications element#25184
rullzer merged 1 commit into
masterfrom
feature/noid/first-class-citizen-notifications

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Since there seems to be an issue with the old way notifications is mounted,
we now hardcode it as suggested by @skjnldsv

Since there seems to be an issue with the old way notifications is mounted,
we now hardcode it.
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added bug 3. to review Waiting for reviews labels Jan 18, 2021
@nickvergessennickvergessen added this to the Nextcloud 21 milestone Jan 18, 2021
nickvergessen added a commit to nextcloud/notifications that referenced this pull request Jan 18, 2021
Based on nextcloud/server#25184
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

The error is because the notifications PR nextcloud/notifications#840 is not in.
So either needs merging before the other

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv

Copy link
Copy Markdown
Member
 And I see that the contact "user0" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
Failed asserting that true is false.

restarted tests

@rullzerrullzer mentioned this pull request Jan 19, 2021
15 tasks
@rullzer
rullzer merged commit 3406032 into masterJan 19, 2021
@rullzer
rullzer deleted the feature/noid/first-class-citizen-notifications branch January 19, 2021 18:40
npmbuildbot-nextcloudBot pushed a commit to nextcloud/notifications that referenced this pull request Jan 19, 2021
Based on nextcloud/server#25184
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@skjnldsv@rullzer