Skip to content

Bump phpseclib/phpseclib from 2.0.25 to 2.0.30 - #25214

Merged
MorrisJobke merged 3 commits into
masterfrom
dependabot/composer/phpseclib/phpseclib-2.0.30
Jan 21, 2021
Merged

Bump phpseclib/phpseclib from 2.0.25 to 2.0.30#25214
MorrisJobke merged 3 commits into
masterfrom
dependabot/composer/phpseclib/phpseclib-2.0.30

Conversation

@ChristophWurst

Copy link
Copy Markdown
Member

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rullzerrullzer mentioned this pull request Jan 19, 2021
15 tasks
@ChristophWurst
ChristophWurstforce-pushed the dependabot/composer/phpseclib/phpseclib-2.0.30 branch from e82e6fa to 15aab23CompareJanuary 19, 2021 19:18
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
ChristophWurstforce-pushed the dependabot/composer/phpseclib/phpseclib-2.0.30 branch from 15aab23 to 4373afeCompareJanuary 19, 2021 20:19
@rullzer

rullzer commented Jan 20, 2021

Copy link
Copy Markdown
Member

Ok got it. So the new phpseclib fails on parsing the root.crt since it contains more than 1 cert.
Before it just only took the first one.

We still ahve to fix:

  • the check app
  • the check core

So we have to split it manually and do it ourselves
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* @return string[]
*/
private function splitCerts(string $cert): array {
preg_match_all('([\-]{3,}[\S\ ]+?[\-]{3,}[\S\s]+?[\-]{3,}[\S\ ]+?[\-]{3,})', $cert, $matches);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily we have tests that confirm this 🙈

@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

I think drone got stuck

@rullzerrullzer mentioned this pull request Jan 21, 2021
19 tasks
@rullzer

Copy link
Copy Markdown
Member

yeah restarted it so lets see

@faily-bot

faily-botBot commented Jan 21, 2021

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1555: failure

acceptance-app-files-sharing-link

  • tests/acceptance/features/app-files-sharing-link.feature:147
Show full log
 Scenario: access a shared link protected by password with an invalid password # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:147
Given I act as John # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I share the link for "welcome.txt" protected by the password "abcdef" # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
│ The password protect field was not found disabled after 50 seconds, assumming that it was disabled and enabled again before the check started and continuing
And I write down the shared link # FilesAppSharingContext::iWriteDownTheSharedLink()
Element is no longer attached to the DOM
For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
System info: host: '5f508e1d53d8', ip: '172.28.0.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-124-generic', java.version: '1.8.0_91'
Driver info: driver.version: unknown (WebDriver\Exception\StaleElementReference)
When I act as Jane # ActorContext::iActAs()
And I visit the shared link I wrote down # PublicShareContext::iVisitTheSharedLinkIWroteDown()
And I authenticate with password "fedcba" # PublicShareContext::iAuthenticateWithPassword()
Then I see that the current page is the Authenticate page for the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown()
And I see that a wrong password for the shared file message is shown # PublicShareContext::iSeeThatAWrongPasswordForTheSharedFileMessageIsShown()

@rullzer

Copy link
Copy Markdown
Member

So now different tests
So lets do this.

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@MorrisJobke
MorrisJobke merged commit 10214fb into masterJan 21, 2021
@MorrisJobke
MorrisJobke deleted the dependabot/composer/phpseclib/phpseclib-2.0.30 branch January 21, 2021 09:25
@LecrisUTLecrisUT mentioned this pull request Jan 25, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst@rullzer@nickvergessen@MorrisJobke