Catch NotFoundException when querying quota

[PVince81]

Fixes parent folder that becomes inaccessible when it contains a
non-existing / broken entry because the quota check made the PROPFIND
on parent fail altogether.

Steps to reproduce

1. Create a folder "test/regular"
2. Create a folder "test/broken"
3. Patch Filesystem::isValidPath and make it return false in case it detects the word "broken" (to simulate non-existence), see patch below
4. Try accessing the "test" and then "regular" folder in web UI

Before the fix

Error that "test" folder cannot be accessed. This also makes "test/regular" inaccessible.

After the fix

Entering the "test" folder works and "regular" accessible.
The "broken" entry is still there and cannot be entered, but that's ok for now as it's broken. Most important is to not block access to the other working entries.

Patch for reproduction

diff --git a/lib/private/Files/Filesystem.php b/lib/private/Files/Filesystem.php
index bf94be273f..d3d83f0b6d 100644
--- a/lib/private/Files/Filesystem.php+++ b/lib/private/Files/Filesystem.php@@ -587,6 +587,10 @@ class Filesystem {
* @return bool
*/
public static function isValidPath($path) {
+ if (stripos($path, 'broken') !== false) {+ // simulate broken entry+ return false;+ }
$path = self::normalizePath($path);
if (!$path || $path[0] !== '/') {
$path = '/' . $path;

[PVince81]

/backport to stable20

[nickvergessen]

🐘