Uh oh!
There was an error while loading. Please reload this page.
Fix valid storages removed when cleaning remote storages - #25331
Merged
MorrisJobke merged 2 commits intoMar 18, 2021
Merged
Conversation
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
requested review from
MorrisJobke, juliusknorr, rullzer and schiessleJanuary 26, 2021 10:42
danxuliu
commented
Jan 26, 2021
MemberAuthor
/backport to stable20 |
danxuliu
commented
Jan 26, 2021
MemberAuthor
/backport to stable19 |
rullzer
approved these changes
Jan 27, 2021
The remote URL of a share is always stored in the database with a trailing slash. However, when a cloud ID is generated trailing slashes are removed. The ID of a remote storage is generated from the cloud ID, but the "cleanup-remote-storage" command directly used the remote URL stored in the database. Due to this, even if the remote storage was valid, its ID did not match the ID of the remote share generated by the command and ended being removed. Now the command generates the ID of remote shares using the cloud ID instead, just like done by the remote storage, so there is no longer a mismatch. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliuforce-pushed
the
fix-valid-storages-removed-when-cleaning-remote-storages
branch
from
January 28, 2021 20:43
91ff735 to
9ccabffCompare Merged
rullzer
commented
Feb 2, 2021
Member
/backport to stable21 |
MorrisJobke
deleted the
fix-valid-storages-removed-when-cleaning-remote-storages
branch
March 18, 2021 07:57
This was referenced Mar 18, 2021
PVince81
commented
Mar 18, 2021
Member
so after just merging this, psalm is unhappy about the merge: https://github.com/nextcloud/server/actions/runs/664180405 |
MorrisJobke
commented
Mar 18, 2021
Member
Is this triggered by our change? |
PVince81
commented
Mar 18, 2021
Member
seems not, probably a hiccup from Github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remote URL of a share is always stored in the database with a trailing slash. However, when a cloud ID is generated trailing slashes are removed.
The ID of a remote storage is generated from the cloud ID, but the
cleanup-remote-storagecommand directly used the remote URL stored in the database. Due to this, even if the remote storage was valid, its ID did not match the ID of the remote share generated by the command and ended being removed.Now the command generates the ID of remote shares using the cloud ID instead, just like done by the remote storage, so there is no longer a mismatch.