Fix/app fetcher php compat comparison by ChristophWurst · Pull Request #25335 · nextcloud/server

ChristophWurst · 2021-01-26T15:39:36Z

Reverts bedd9ac.

This is how #24416 was meant to work.

Note to testers: there is some caching that might make it impossible to see the fix immediately. Apply the changes as patch from https://patch-diff.githubusercontent.com/raw/nextcloud/server/pull/25335.patch, give the cache an hour or so to expire and try again

This reverts commit bedd9ac.

When app app specifies php 7.4 as upper limit we have to allow the installation on php>7.4.0. The previous version check didn't do that. This adjusts the regexes to discard any irrelevant suffix after the three version numbers so that we can use more fine granular checks than php's version_compare can do out of the box, like for php 7.4 we only compare the major and minor version numbers and ignore the patch level. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

kesselb

LGTM

nickvergessen · 2021-01-26T17:38:34Z

+ ['13.0.1-beta.1', '13', '<=', true],
+ ['7.4.14', '7.4', '<=', true],
+ ['7.4.14-ubuntu', '7.4', '<=', true],
+ ['7.4.14-ubuntu', '7.4.15', '<=', true],


Can we also have a false test with Ubuntu

szaimen · 2021-01-27T14:39:09Z

Will this get backported to NC20?

ChristophWurst · 2021-01-27T14:49:28Z

/backport to stable20

ManafxMT · 2021-01-28T16:19:40Z

Hello Christoph
I have the same problem - Email disappered since my update to 20.0.6.

How to implement the patch please?
Do you have a link where I can read about the procedure?

I never had an issue like this before.

ChristophWurst · 2021-01-28T19:23:06Z

Let me show you a magic trick. The PR URL is https://github.com/nextcloud/server/pull/25335. Now append a .patch and you will be redirected to https://patch-diff.githubusercontent.com/raw/nextcloud/server/pull/25335.patch. Download that patch.

Then you can use your patch command to apply the changes: https://www.cyberciti.biz/faq/appy-patch-file-using-patch-command/.

vladlucky · 2021-01-28T21:28:01Z

Having the same issue as described here by others - unable to locate/enable the TOTP app in Nextcloud.

I've tried to apply the patch but am getting the following response. I have a brand new installation of Nextcloud 20.0.6.1 with Ubuntu 20.04.1 LTS and PHP 7.4.14.

I am a total nub to Nextcloud administration and git, this was my first build so any help will be much appreciated.

ManafxMT · 2021-01-29T09:51:32Z

Do besides being a developer you are a magician too 👍💐
First, thanks for your quick response.
Let me understand: if not installed, I need to install "patch".
After that, in the terminal I only put
Patch (downloadpath.patch)?
With or without sudo?
Is there a chance to messup my whole installation- so shall I do a backup before?
I found some videos around the patch command, but still not sure...

ChristophWurst · 2021-01-29T09:54:40Z

patch -p1 < 25335.patch should be the command. No sudo required although you possible want to run this as your web server user, like sudo -u www-data patch … on Debian/Ubuntu.

ManafxMT · 2021-01-29T10:59:26Z

Turbo response, thanks.
Before I try it: when will be the app available in the app section on 20.06 again?
Maybe I better wait for it...

ChristophWurst · 2021-01-29T14:32:04Z

it looks like we can release 20.0.7 next week, but I can't promise it

ManafxMT · 2021-01-29T14:40:36Z

Cool, I think I better wait - if there is a slight chance to mess up the patch - I will manage. (joking).
Thanks for your time and explainations...will be very helpful for others for sure.

vladlucky · 2021-01-29T18:09:45Z

Thank your Christoph, the patch resolved the issue and I am now able to install the TOTP plug-in!

vladlucky · 2021-01-31T04:01:06Z

Although TOTP is working after applying the patch, I started seeing the following errors. In addition to seeing the errors, the app store is not always accessible - sometimes it loads sometimes it doesn't:

ChristophWurst · 2021-02-01T06:29:52Z

the app store was down, that's why you saw a "new" exception

natrius · 2021-02-02T15:37:04Z

Just to clarify: This seems to resolve the problem with extracting Nextcloud News as well? nextcloud/news#1086

ManafxMT · 2021-02-03T13:07:42Z

I installed NC 20.0 7 and the Email App - all works great, thanks a lot.
It is reacting faster then before too.

Only it is not keeping my signature - can I do something about it?

ManafxMT · 2021-02-03T13:25:36Z

Managed - even with the signature.
Total happy now.

You are doing an awesome job 👍👍

ChristophWurst · 2021-02-03T14:18:49Z

Just to clarify: This seems to resolve the problem with extracting Nextcloud News as well? nextcloud/news#1086

nextcloud/news#1086 (comment).

Only it is not keeping my signature - can I do something about it?

Known regression but feel free to report is as bug for better tracking.

✌️

fischer-felix · 2021-02-03T16:37:31Z

patch -p1 < 25335.patch should be the command. No sudo required although you possible want to run this as your web server user, like sudo -u www-data patch … on Debian/Ubuntu.

How would you apply this patch when using a nextcloud snap installation?

ChristophWurst · 2021-02-03T16:51:12Z

How would you apply this patch when using a nextcloud snap installation?

Please ask on https://help.nextcloud.com/c/support/7

DennisWilken · 2021-02-07T17:40:50Z

Hi Christoph, thanks for your patch. I am trying to install it on a Docker container. But I am not quite sure how to apply it. I downloaded it using curl https://patch-diff.githubusercontent.com/raw/nextcloud/server/pull/25335.patch -o 25335.patch
and tried to install it using patch -p1 < 25335.patch. Next, I am asked for the file to patch:

Do I have to run the patch in a certain folder? What path do I have to enter? Am I doing anything else wrong? Thanks for your help!

szaimen · 2021-02-07T17:44:51Z

@DennisWilken just update your NC to 20.0.7 (it is included with this version). There is no need to apply the fix manually.

DennisWilken · 2021-02-07T19:03:25Z

@DennisWilken just update your NC to 20.0.7 (it is included with this version). There is no need to apply the fix manually.

Version 20.0.7 is not yet available on docker (see here) So I can either wait, patch or manually upgrade.

ChristophWurst added 2 commits January 26, 2021 13:48

Revert "Fix comparison of PHP versions"
652bf9d
This reverts commit bedd9ac.

ChristophWurst added bug 3. to review Waiting for reviews feature: apps management regression labels Jan 26, 2021

ChristophWurst added this to the Nextcloud 21 milestone Jan 26, 2021

ChristophWurst requested review from kesselb, nickvergessen and rullzer January 26, 2021 15:39

ChristophWurst self-assigned this Jan 26, 2021

ChristophWurst mentioned this pull request Jan 26, 2021
Mail app not available for installation nextcloud/mail#4383
Closed

kesselb approved these changes Jan 26, 2021
View reviewed changes

nickvergessen approved these changes Jan 26, 2021
View reviewed changes

rullzer merged commit 3a9c7f9 into masterJan 27, 2021

rullzer deleted the fix/app-fetcher-php-compat-comparison branch January 27, 2021 14:14

rullzer mentioned this pull request Jan 27, 2021
21 beta8 #25245
Merged
19 tasks

backportbot-nextcloudBot added the backport-request label Jan 27, 2021

backportbot-nextcloudBot mentioned this pull request Jan 27, 2021
[stable20] Fix/app fetcher php compat comparison #25347
Merged

backportbot-nextcloudBot removed the backport-request label Jan 27, 2021

ChristophWurst mentioned this pull request Jan 28, 2021
App not visible nor installable in NC 20.0.5 nextcloud/twofactor_totp#1066
Closed

anoymouserver mentioned this pull request Jan 30, 2021
NC Update to 20, cannot update News anymore 14.2.2 -> 15.1.1 nextcloud/news#1086
Closed
3 tasks

Rello mentioned this pull request Feb 1, 2021
Couldn't find Analytics app on nextcloud app list Rello/analytics#104
Closed

pachulo mentioned this pull request Feb 2, 2021
20.0.6 Has Hit the Changelog nextcloud-snap/nextcloud-snap#1619
Closed

ChristophWurst mentioned this pull request Feb 3, 2021
No app update available for 20.0.7 nextcloud/twofactor_totp#1073
Closed

kyrofa mentioned this pull request Feb 4, 2021
Odd App Store Behavior nextcloud-snap/nextcloud-snap#1640
Closed

sokai mentioned this pull request Feb 8, 2021
Not compatible with Nextcloud 20.0.7 nc-music/oc-music#820
Closed

Potherca mentioned this pull request Apr 7, 2021
Could not extract app solid pdsinterop/solid-nextcloud#43
Closed

Uh oh!

Uh oh!

Conversation

ChristophWurst commented Jan 26, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kesselb left a comment

Choose a reason for hiding this comment

Uh oh!

nickvergessenJan 26, 2021

Choose a reason for hiding this comment

Uh oh!

ChristophWurstJan 27, 2021

Choose a reason for hiding this comment

Uh oh!

szaimen commented Jan 27, 2021

Uh oh!

ChristophWurst commented Jan 27, 2021

Uh oh!

ManafxMT commented Jan 28, 2021

Uh oh!

ChristophWurst commented Jan 28, 2021

Uh oh!

vladlucky commented Jan 28, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ManafxMT commented Jan 29, 2021

Uh oh!

ChristophWurst commented Jan 29, 2021

Uh oh!

ManafxMT commented Jan 29, 2021

Uh oh!

ChristophWurst commented Jan 29, 2021

Uh oh!

ManafxMT commented Jan 29, 2021

Uh oh!

vladlucky commented Jan 29, 2021

Uh oh!

vladlucky commented Jan 31, 2021

Uh oh!

ChristophWurst commented Feb 1, 2021

Uh oh!

natrius commented Feb 2, 2021

Uh oh!

ManafxMT commented Feb 3, 2021

Uh oh!

ManafxMT commented Feb 3, 2021

Uh oh!

ChristophWurst commented Feb 3, 2021

Uh oh!

fischer-felix commented Feb 3, 2021

Uh oh!

ChristophWurst commented Feb 3, 2021

Uh oh!

DennisWilken commented Feb 7, 2021

Uh oh!

szaimen commented Feb 7, 2021

Uh oh!

DennisWilken commented Feb 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

ChristophWurst commented Jan 26, 2021•
edited
Loading

vladlucky commented Jan 28, 2021•
edited
Loading