Uh oh!
There was an error while loading. Please reload this page.
dont return private storage interface from public mount interface - #25392
Merged
Conversation
kesselb
approved these changes
Jan 31, 2021
kesselb
commented
Jan 31, 2021
Contributor
Psalm is a bit unhappy. server/lib/public/Files/Storage/IStorage.php Line 439 in d1bdd1c server/lib/private/Files/Storage/Common.php Line 334 in d1bdd1c |
icewind1991
commented
Feb 1, 2021
MemberAuthor
and now psalm just crashes... |
kesselb
commented
Feb 1, 2021
Contributor
😞 It seems that a dev version is used for the security checks. I would ignore them for now and just care about
|
rullzer
commented
Feb 2, 2021
Member
Master is Nextcloud 22 now. |
rullzerforce-pushed
the
imountpoint-ocp-storage
branch
from
February 11, 2021 09:32
9fde931 to
a70f4a5ComparePVince81
commented
Mar 17, 2021
Member
@icewind1991 please rebase for psalm and/or fix psalm issues |
rullzerforce-pushed
the
imountpoint-ocp-storage
branch
from
March 22, 2021 20:14
a70f4a5 to
200e11aComparerullzer
commented
Mar 22, 2021
Member
Seems psalm is right. Also with respect to the failed cache that doesn't fit the hierarchy... |
icewind1991force-pushed
the
imountpoint-ocp-storage
branch
from
March 23, 2021 11:16
200e11a to
7e44668CompareSigned-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
imountpoint-ocp-storage
branch
from
March 23, 2021 11:25
7e44668 to
7995c6eCompareicewind1991
commented
Mar 23, 2021
MemberAuthor
psalm is happy |
rullzer
commented
Mar 30, 2021
Member
Ah but conflicts now :( |
blizzz
commented
Jun 2, 2021
Member
@icewind1991 conflicts |
Merged
skjnldsv
approved these changes
Oct 22, 2021
juliusknorr
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robin Appelman robin@icewind.nl