Skip to content

add repair job for unencoded group share uris - #25393

Merged
rullzer merged 4 commits into
masterfrom
fix/25165/repair-dav-shares
Feb 2, 2021
Merged

add repair job for unencoded group share uris#25393
rullzer merged 4 commits into
masterfrom
fix/25165/repair-dav-shares

Conversation

@blizzz

@blizzzblizzz commented Jan 29, 2021•
edited
Loading

Copy link
Copy Markdown
Member

fixes#25165

the test file shows the scenarios: we try to detect uris that are not encoded and encoding would for sure they that they would match an existing group.

A side effect I found: if an old broken share was present next to a new valid share, it would be updated successfully despite the UNIQUE index on Postgres, because PostgreSQL consider NULL columns not equal in this case. Hence, the second commit that introduces the grouping by both selected columns.→ https://www.postgresql.org/docs/current/ddl-constraints.html#DDL-CONSTRAINTS-UNIQUE-CONSTRAINTS

@blizzzblizzz added this to the Nextcloud 21 milestone Jan 29, 2021
@blizzz

blizzz commented Jan 29, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@blizzz

blizzz commented Jan 29, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@blizzz
blizzzforce-pushed the fix/25165/repair-dav-shares branch from 2fd34ca to fc61990CompareJanuary 29, 2021 16:17
ChristophWurst
ChristophWurst reviewed Jan 29, 2021
View reviewed changes
Comment threadlib/private/Repair/RepairDavShares.php
Comment threadlib/private/Repair/RepairDavShares.php
Comment threadlib/private/Repair/RepairDavShares.php Outdated
ChristophWurst
ChristophWurst reviewed Jan 29, 2021
View reviewed changes
Comment threadlib/private/Repair/RepairDavShares.php
@blizzz
add repair job for unencoded calendars
558f062
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
take into account that UNIQUE index might not work as expected
bd8b431
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzzforce-pushed the fix/25165/repair-dav-shares branch from fc61990 to bd8b431CompareJanuary 29, 2021 16:29
@blizzz
show suggestion to clean up possible invalid shares later
3ecc6d0
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
ChristophWurst
ChristophWurst approved these changes Jan 29, 2021
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code
Tests
👍

@blizzz
test: adjust expectation
d4a45b4
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@rullzerrullzer modified the milestones: Nextcloud 21, Nextcloud 22Feb 2, 2021
@rullzer

rullzer commented Feb 2, 2021

Copy link
Copy Markdown
Member

/backport to stable21

@rullzer
rullzer merged commit 5c6d245 into masterFeb 2, 2021
@rullzer
rullzer deleted the fix/25165/repair-dav-shares branch February 2, 2021 20:43
This was referenced Feb 2, 2021
Merged
Merged
Merged
@tcitworldtcitworld mentioned this pull request Feb 14, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: dav

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

Group shared calendars missing (20.0.5)

3 participants

@blizzz@rullzer@ChristophWurst