Skip to content

Keep direct login active when redirecting - #25424

Merged
juliusknorr merged 1 commit into
masterfrom
bugfix/noid/direct-login-fail
Feb 2, 2021
Merged

Keep direct login active when redirecting#25424
juliusknorr merged 1 commit into
masterfrom
bugfix/noid/direct-login-fail

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

When SAML is configured with allowing multiple auth backends and the user uses the direct login method the user was just redirected to the auth picker again. This makes sure that we always end up in the direct login form where the error about the wrong credentials is displayed.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 2, 2021
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Psalm failure is unrelated

@juliusknorr
juliusknorr merged commit 392dc8b into masterFeb 2, 2021
@juliusknorr
juliusknorr deleted the bugfix/noid/direct-login-fail branch February 2, 2021 09:27
@rullzerrullzer mentioned this pull request Feb 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@rullzer@nickvergessen@ChristophWurst