Uh oh!
There was an error while loading. Please reload this page.
[stable20] Make user list pagination more tolerant - #25475
Merged
Conversation
backportbot-nextcloudBot
requested review from
ChristophWurst, PVince81, juliusknorr, nickvergessen and rullzerFebruary 4, 2021 08:37
PVince81force-pushed
the
backport/25443/stable20
branch
from
February 4, 2021 10:02
5ef01aa to
a9716ddCompareMember
I've rebuilt the assets with "make dev-setup && make build-js-production", squashed and retested. I'm just a bit surprised that the asset builder decided to delete some files: |
PVince81
commented
Feb 4, 2021
Member
the same happens on another PR where it would also delete exactly these files :-/ |
This was referenced Feb 4, 2021
PVince81
commented
Feb 4, 2021
Member
I've pushed that strange removal as a separate PR #25480 for further discussion. |
PVince81
commented
Feb 5, 2021
Member
failing acceptance sharing test unrelated to settings |
PVince81
commented
Feb 5, 2021
Member
I've raised #25491 to look into the failed sharing acceptance test as it seems to happen consistently on stable20. |
Merged
In case the server returns more results than expected by the limit, it is now still interpreted as there being more results to query. This situation can happen when there are multiple user backends in place. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81force-pushed
the
backport/25443/stable20
branch
from
February 5, 2021 10:08
a9716dd to
ccaa593ComparePVince81
commented
Feb 5, 2021
Member
rebased to get CI green |
rullzer
approved these changes
Feb 5, 2021
ChristophWurst
approved these changes
Feb 5, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #25443