Skip to content

fix(translation): replace static error message - #25500

Merged
rullzer merged 3 commits into
nextcloud:masterfrom
Worteks:fix-sharemanager-genericshareexception
Feb 5, 2021
Merged

fix(translation): replace static error message#25500
rullzer merged 3 commits into
nextcloud:masterfrom
Worteks:fix-sharemanager-genericshareexception

Conversation

@faust64

@faust64faust64 commented Feb 5, 2021

Copy link
Copy Markdown
Contributor

as suggested by @kesselb in #25490

@faust64
fix(translation): replace static error message
59e43b4
as suggested by @kesselb in nextcloud#25490
Signed-off-by: Samuel <faust64@gmail.com>
kesselb
kesselb reviewed Feb 5, 2021
View reviewed changes
Comment threadlib/private/Share20/Manager.php Outdated
@faust64
revert(exception): keep throwing an exception for now
5f8dfa8
Signed-off-by: Samuel <faust64@gmail.com>
@kesselbkesselb added 2. developing Work in progress bug labels Feb 5, 2021
@faust64
revert(comment)
3a077a3
Signed-off-by: Samuel <faust64@gmail.com>
PVince81
PVince81 approved these changes Feb 5, 2021
View reviewed changes

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense as other user-visible exceptions are translated too

@kesselbkesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 5, 2021
@rullzer
rullzer merged commit 6e46124 into nextcloud:masterFeb 5, 2021
@welcome

welcomeBot commented Feb 5, 2021

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@rullzerrullzer added this to the Nextcloud 22 milestone Feb 5, 2021
@rullzer

rullzer commented Feb 5, 2021

Copy link
Copy Markdown
Member

/backport to stable21

@rullzer

rullzer commented Feb 5, 2021

Copy link
Copy Markdown
Member

/backport to stable20

@rullzer

rullzer commented Feb 5, 2021

Copy link
Copy Markdown
Member

/backport to stable19

@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 5, 2021

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 5, 2021

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 5, 2021
Merged
@faust64
faust64 deleted the fix-sharemanager-genericshareexception branch February 8, 2021 08:58
@MorrisJobke

MorrisJobke commented Mar 16, 2021

Copy link
Copy Markdown
Member

@rullzer Backports failed :/

@rullzer

rullzer commented Mar 30, 2021

Copy link
Copy Markdown
Member

/backport to stable20

@rullzer

rullzer commented Mar 30, 2021

Copy link
Copy Markdown
Member

/backport to stable21

This was referenced Mar 30, 2021
Merged
Merged
@nickvergessen

nickvergessen commented Mar 30, 2021

Copy link
Copy Markdown
Member

Should we use GenericShareException

@rullzer

rullzer commented Mar 30, 2021

Copy link
Copy Markdown
Member

Should we use GenericShareException

Yeah might make sense now

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81PVince81PVince81 approved these changes
@kesselbkesselbkesselb approved these changes

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

6 participants

@faust64@rullzer@MorrisJobke@nickvergessen@PVince81@kesselb