Uh oh!
There was an error while loading. Please reload this page.
Fix the legacy dispatcher argument order - #25531
Merged
Merged
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurstforce-pushed
the
fix/dispatcher-argument-order
branch
from
February 9, 2021 09:47
93100b6 to
abc61a9CompareChristophWurst
requested review from
PVince81, blizzz, gary-kim, kesselb and rullzerFebruary 9, 2021 09:49
ChristophWurst
marked this pull request as ready for review
February 9, 2021 09:49
kesselb
approved these changes
Feb 9, 2021
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 2059: failurecheckers
mysql8.0-php7.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony switched the argument order to comply with the PSR dispatcher but we still use it wrong in many places. Also the way we extend the interface is technically wrong …
So this all works more or less by chance. After the PR it's a bit more reliable: you can use the adapter in both fashions.