Skip to content

Deprecate the internal IDBConnection event name constants - #25543

Merged
ChristophWurst merged 1 commit into
masterfrom
deprecate/idb-events
Feb 9, 2021
Merged

Deprecate the internal IDBConnection event name constants#25543
ChristophWurst merged 1 commit into
masterfrom
deprecate/idb-events

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Feb 9, 2021•
edited
Loading

Copy link
Copy Markdown
Member

I'm also ok with doing this even for 21.0.0 …

@ChristophWurst
Deprecate the internal IDBConnection event name constants
3d075c3
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurstChristophWurst added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Feb 9, 2021
@ChristophWurstChristophWurst added this to the Nextcloud 22 milestone Feb 9, 2021
@ChristophWurstChristophWurst self-assigned this Feb 9, 2021
@faily-bot

faily-botBot commented Feb 9, 2021

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 2061: failure

checkers

@ChristophWurstChristophWurst added the pending documentation This pull request needs an associated documentation update label Feb 9, 2021
@ChristophWurst

ChristophWurst commented Feb 9, 2021

Copy link
Copy Markdown
MemberAuthor

CI is happy, checkers are fixed with #25542

rullzer
rullzer approved these changes Feb 9, 2021
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this and move #25471 forward then. Maybe by adding the remaining things as well.

@ChristophWurstChristophWurst mentioned this pull request Feb 9, 2021
Closed
5 tasks
@nickvergessen

nickvergessen commented Feb 9, 2021

Copy link
Copy Markdown
Member

Did we add this for 20 or 21, then we could just remove it

@nickvergessen

nickvergessen commented Feb 9, 2021

Copy link
Copy Markdown
Member

Ah two were backported to 20 and the others were there before

@ChristophWurst
ChristophWurst merged commit f96f0f6 into masterFeb 9, 2021
@ChristophWurst
ChristophWurst deleted the deprecate/idb-events branch February 9, 2021 17:50
@ChristophWurstChristophWurst removed the pending documentation This pull request needs an associated documentation update label Jul 5, 2021
@ChristophWurstChristophWurst mentioned this pull request Jul 5, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@nickvergessennickvergessennickvergessen approved these changes
@kesselbkesselbAwaiting requested review from kesselb

Assignees

@ChristophWurstChristophWurst

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristophWurst@nickvergessen@rullzer