Uh oh!
There was an error while loading. Please reload this page.
Avoid creating two share links when password is enforced - #25602
Merged
Conversation
skjnldsv
self-requested a review
February 19, 2021 10:26
skjnldsvforce-pushed
the
bugfix/noid/only-create-share-once
branch
from
February 19, 2021 11:02
367b63d to
c534e8bCompareskjnldsv
marked this pull request as ready for review
February 19, 2021 11:02
skjnldsv
commented
Feb 19, 2021
Member
/backport to stable21 |
skjnldsv
commented
Feb 19, 2021
Member
/backport to stable20 |
skjnldsv
commented
Feb 19, 2021
Member
/backport to stable19 |
skjnldsv
commented
Feb 19, 2021
Member
/compile amend / |
Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
npmbuildbot-nextcloudBotforce-pushed
the
bugfix/noid/only-create-share-once
branch
from
February 19, 2021 11:16
c534e8b to
9073c09CompareChristophWurst
approved these changes
Feb 19, 2021
skjnldsv
approved these changes
Feb 22, 2021
This was referenced Feb 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
💥 See that the share link was created twice
The main reason is that the close of the modal also triggers the share creation