Uh oh!
There was an error while loading. Please reload this page.
Type the experssionbuilders - #25656
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 2405: failuresqliteShow full logmariadb10.1-php7.3Show full logmariadb10.4-php7.4Show full logmysql8.0-php7.4Show full logpostgres9.6-php7.3Show full logpostgres11-php7.4Show full logpostgres12-php7.4Show full logpostgres13-php7.4Show full log |
9f753e2 to
de56159CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rullzer
commented
Mar 2, 2021
Resolved @nickvergessen |
nickvergessen
commented
Mar 3, 2021
Time to squash and fixup? |
22f3b30 to
4bdf9f5CompareSigned-off-by: Roeland Jago Douma <roeland@famdouma.nl>
| * @psalm-taint-sink sql $type | ||
| */ | ||
| public function castColumn($column, $type); | ||
| public function castColumn(string $column, $type): IQueryFunction; |
There was a problem hiding this comment.
So before this allowed to also cast "expressions" (like functions).
It was used e.g. in the user_usage_report app:
nextcloud/user_usage_report#69 (comment)
Before:
UPDATE`oc_preferences`SET`configvalue`= (`configvalue`+1) WHERE (`userid`= :user) AND (`configkey`= :action) AND (`appid`= :appid)After:
UPDATE`oc_preferences`SET`configvalue`=`(`configvalue` + 1)`WHERE (`userid`= :user) AND (`configkey`= :action) AND (`appid`= :appid)
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl