Skip to content

Show group backends in occ group:list --info and group:info - #25660

Merged
rullzer merged 1 commit into
nextcloud:masterfrom
hosting-de:feature/add-backend-list-groups
Mar 5, 2021
Merged

Show group backends in occ group:list --info and group:info#25660
rullzer merged 1 commit into
nextcloud:masterfrom
hosting-de:feature/add-backend-list-groups

Conversation

@noiob

@noiobnoiob commented Feb 15, 2021

Copy link
Copy Markdown
Contributor

When using LDAP, it may be necessary to check whether a group is managed by LDAP or the Database backend. I've added that info both to the group:list command when run with --info (as to not introduce breaking changes) and to the new group:info command. I've tried to keep them similar to user:list --info and user:info.

@noiob
noiobforce-pushed the feature/add-backend-list-groups branch 3 times, most recently from f8e8ac6 to c5b9ee4CompareFebruary 16, 2021 10:01
@noiob
noiob marked this pull request as draft February 16, 2021 10:02
@noiob
noiobforce-pushed the feature/add-backend-list-groups branch from c5b9ee4 to 45c2dbcCompareFebruary 16, 2021 10:08
@noiob
noiob marked this pull request as ready for review February 16, 2021 10:10
@noiob
noiobforce-pushed the feature/add-backend-list-groups branch 2 times, most recently from d9aa41f to 0c8b322CompareFebruary 16, 2021 16:25
@kesselb

kesselb commented Feb 17, 2021

Copy link
Copy Markdown
Contributor

Thanks a lot 👍

Please migrate to CamelCase for variable names.

@noiob
noiobforce-pushed the feature/add-backend-list-groups branch from 0c8b322 to 5e8a029CompareFebruary 17, 2021 13:49
@noiob

noiob commented Feb 17, 2021

Copy link
Copy Markdown
ContributorAuthor

Please migrate to CamelCase for variable names.

done, hope I didn't miss any!

@noiob
noiobforce-pushed the feature/add-backend-list-groups branch from 5e8a029 to a3542deCompareFebruary 17, 2021 14:38
blizzz
blizzz reviewed Feb 17, 2021
View reviewed changes

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thank you for the contribution!

Comment threadcore/Command/Group/Info.php Outdated
Comment threadcore/Command/Group/Info.php Outdated
Comment threadcore/register_command.php Outdated
Comment threadlib/private/Group/Group.php Outdated
Comment threadlib/public/IGroup.php Outdated
@noiob
noiobforce-pushed the feature/add-backend-list-groups branch 6 times, most recently from 0e1f3da to 9b556e5CompareFebruary 22, 2021 18:16
@noiob

noiob commented Feb 22, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@blizzz Thanks for the comprehensive review, I tried to implement all the changes you requested, it feels a good bit more elegant now 😄
I think the php-cs check isn't actually failing in my code, but in apps/sharebymail/lib/Settings/SettingsManager.php

Edit: I have opened a PR for the issue in sharebymail SettingsManager at #25778

@noiob
noiob requested a review from blizzzFebruary 22, 2021 21:48
@noiob
noiobforce-pushed the feature/add-backend-list-groups branch 2 times, most recently from 0a6c0b8 to dce3097CompareMarch 1, 2021 13:41
Johannes Leuker
Show group backends in occ group:list --info and group:info
2796ef8
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
@noiob
noiobforce-pushed the feature/add-backend-list-groups branch from dce3097 to 2796ef8CompareMarch 1, 2021 15:02
blizzz
blizzz approved these changes Mar 2, 2021
View reviewed changes

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tested + works, has tests, 👍

@rullzer
rullzer merged commit 54cffef into nextcloud:masterMar 5, 2021
@noiob
noiob deleted the feature/add-backend-list-groups branch March 8, 2021 09:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@blizzzblizzzblizzz approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@icewind1991icewind1991Awaiting requested review from icewind1991
@denismosolovdenismosolovAwaiting requested review from denismosolov
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsenhancementfeature: ldapfeature: occfeature: users and groups

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@noiob@kesselb@rullzer@blizzz@nickvergessen