Skip to content

Fix admin password strengthify tooltip - #25712

Merged
skjnldsv merged 1 commit into
masterfrom
fix/noid/admin-password-tooltip
Mar 1, 2021
Merged

Fix admin password strengthify tooltip#25712
skjnldsv merged 1 commit into
masterfrom
fix/noid/admin-password-tooltip

Conversation

@st3iny

@st3inyst3iny commented Feb 18, 2021

Copy link
Copy Markdown
Member

Fixes the admin password strengthify tooltip not being shown on the install page.

Unfortunately, the console is spammed with unavoidable deprecation warnings (ref #12980):
tooltip.js:36 Deprecated call $.tooltip('fixTitle') has been deprecated and should be removed

This has to be fixed in the upstream library at https://github.com/MorrisJobke/strengthify.

Before

tooltip-before

Console error:

jquery.strengthify.js:158 Uncaught TypeError: $wrapper.attr(...).tooltip is not a function
at HTMLInputElement.drawStrengthify (jquery.strengthify.js:158)
at HTMLInputElement.dispatch (jquery.js:5183)
at HTMLInputElement.elemData.handle (jquery.js:4991)

After

tooltip-after

@st3inyst3iny added the 3. to review Waiting for reviews label Feb 18, 2021
@st3inyst3iny self-assigned this Feb 18, 2021
@st3iny
st3inyforce-pushed the fix/noid/admin-password-tooltip branch from 4e2107a to a785da3CompareFebruary 19, 2021 08:48
@st3iny

st3iny commented Feb 19, 2021

Copy link
Copy Markdown
MemberAuthor

Rebased and fixed node build job

@st3iny
Fix admin password strengthify tooltip
2771e44
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny
st3inyforce-pushed the fix/noid/admin-password-tooltip branch from a785da3 to 2771e44CompareFebruary 22, 2021 20:31
@st3iny
st3iny requested a review from skjnldsvFebruary 23, 2021 10:28
@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 24, 2021
@skjnldsv
skjnldsv merged commit 92d6abf into masterMar 1, 2021
@skjnldsv
skjnldsv deleted the fix/noid/admin-password-tooltip branch March 1, 2021 13:52
@st3iny

st3iny commented Mar 5, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Mar 5, 2021
Merged
@st3iny

st3iny commented Mar 5, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@st3iny

st3iny commented Mar 5, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Mar 5, 2021
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 5, 2021

Copy link
Copy Markdown

The backport to stable19 failed. Please do this backport manually.

@st3inyst3iny mentioned this pull request Mar 5, 2021
Merged
@st3inyst3iny added this to the Nextcloud 22 milestone Mar 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes

Assignees

@st3inyst3iny

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: install and update

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

3 participants

@st3iny@juliusknorr@skjnldsv