Skip to content

apply object store copy optimization when 'cross storage' copy is wit… - #25722

Merged
icewind1991 merged 1 commit into
masterfrom
objectstore-copy-cross
Mar 12, 2021
Merged

apply object store copy optimization when 'cross storage' copy is wit…#25722
icewind1991 merged 1 commit into
masterfrom
objectstore-copy-cross

Conversation

@icewind1991

Copy link
Copy Markdown
Member

…hin the same object store

This applies to copying from/to groupfolders, shares, etc.

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Feb 19, 2021
@icewind1991icewind1991 added this to the Nextcloud 22 milestone Feb 19, 2021
@faily-bot

faily-botBot commented Feb 19, 2021

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 2441: failure

acceptance-users

  • tests/acceptance/features/users.feature:47
Show full log
 Scenario: users navigation without disabled users # /drone/src/tests/acceptance/features/users.feature:47
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
And I see that the list of users contains the user disabledUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user disabledUser # UsersSettingsContext::iOpenTheActionsMenuOf()
Row for user disabledUser in Users Settings could not be found
Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
When I click the "Enable user" action in the disabledUser actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()
When I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()

Comment threadlib/private/Files/ObjectStore/ObjectStoreStorage.php
@icewind1991
icewind1991force-pushed the objectstore-copy-cross branch from 69c485e to eec48faCompareMarch 3, 2021 16:28

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer

Copy link
Copy Markdown
Member

psalm is not happy and neither is the php-cs checker ;)

@icewind1991
icewind1991force-pushed the objectstore-copy-cross branch from eec48fa to ad70b6cCompareMarch 5, 2021 17:10
@icewind1991

Copy link
Copy Markdown
MemberAuthor

made cs and psalm happy and squashed

@rullzer
rullzerforce-pushed the objectstore-copy-cross branch from ad70b6c to c87b1a5CompareMarch 9, 2021 19:31
…hin the same object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
@PVince81

Copy link
Copy Markdown
Member

restarted failed build

@icewind1991
icewind1991 merged commit 32551b9 into masterMar 12, 2021
@icewind1991
icewind1991 deleted the objectstore-copy-cross branch March 12, 2021 16:10
@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@rullzer@PVince81