Uh oh!
There was an error while loading. Please reload this page.
Do not trigger a full filelist reload after creating a new file from a template - #25797
Merged
Conversation
juliusknorr
requested review from
ChristophWurst, danxuliu, rullzer and skjnldsvFebruary 25, 2021 15:49
juliusknorr
commented
Feb 25, 2021
MemberAuthor
/backport to stable21 |
ChristophWurst
approved these changes
Feb 25, 2021
rullzer
commented
Mar 2, 2021
Member
php-cs is not happy.. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorrforce-pushed
the
bugfix/noid/templates-fileactions
branch
from
March 2, 2021 09:46
8df45b6 to
1d5ee03Comparejuliusknorr
commented
Mar 2, 2021
MemberAuthor
Rebased |
rullzer
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of reloading the full file list after creating a file from a template this will now just fetch the single file info and add it to the existing file list. This makes sure we can also provide the regular context parameters when calling the file action.