Uh oh!
There was an error while loading. Please reload this page.
Add appconfig to always show the unique label of a sharee - #25915
Merged
Conversation
juliusknorr
requested review from
ChristophWurst, blizzz, jancborchardt, rullzer and skjnldsvMarch 3, 2021 12:26
juliusknorr
commented
Mar 3, 2021
MemberAuthor
As some additional note, in older versions we just had a tooltip on the avatar with the userid which was used as kind of a workaround for this, but with the new multiselect users cannot really see who they share a file to then. |
skjnldsv
approved these changes
Mar 3, 2021
rullzer
approved these changes
Mar 4, 2021
rullzer
commented
Mar 4, 2021
Member
/compile amend / |
npmbuildbot-nextcloudBotforce-pushed
the
bugfix/noid/option-always-show-unique-label
branch
from
March 4, 2021 07:40
4c3511f to
5a0d43dCompareSigned-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorrforce-pushed
the
bugfix/noid/option-always-show-unique-label
branch
from
March 4, 2021 08:25
5a0d43d to
69c2864Compareblizzz
approved these changes
Mar 4, 2021
juliusknorr
commented
Mar 11, 2021
MemberAuthor
/backport to stable21 |
juliusknorr
commented
Mar 11, 2021
MemberAuthor
/backport to stable20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is quite common in larger environments or in setups that use a lot of guest users that with sharing autocompletion the display name doesn't give enough hint on whom a file is shared with in the end. This PR adds a appconfig flag that can be set in order to always show the email or userid unique shareee label if this is wanted by the admin.